New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667716 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.9%-13.8% improvement in webrtc_perf_tests at 15135:15139

Project Member Reported by peah@chromium.org, Nov 22 2016

Issue description

See the link to graphs below.
 

Comment 1 by peah@chromium.org, Nov 22 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=667716

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgm8HVpQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgm8HssAoM


Bot(s) for this bug's original alert(s):

webrtc-win-large-tests

Comment 2 by peah@chromium.org, Nov 22 2016

Owner: brandtr@chromium.org
brandtr@: Could these regressions also be related to the shortened duration of the tests?
Cc: kjellander@chromium.org
The shortening of the tests happened at #15118, which gives a pretty clear uptick in the graphs (but not a perf alert!). But it's weird that there is later a downtick, where the encode time goes down. In the downtick blamelist, I found this CL: https://codereview.webrtc.org/2505183003, which I don't fully understand.

kjellander@: Did that CL move the Win bots to dedicated machines, thus explaining the reduced encode time in these tests?
That CL is related to the move (which happened within the same hour), but the CL itself only covers removing DCHECKs, which was expected trigger a large number of improvement alerts (as communicated to the sheriffs mailing list).
Status: WontFix (was: Untriaged)
Right, but from the CL description it seemed that only Android bots had their DCHECKs removed. But I see in the email that you sent out that the desktop tests were affected too. Thanks for looking into it!

Sign in to add a comment