New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 667707 link

Starred by 2 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
█ hdodda@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Hover effect stays on all permission icon within omnibox evenafter clicking outside omnibox.

Reported by dmascare...@etouch.net, Nov 22 2016 
Chrome Version:56.0.2924.3 (Official Build) 66f73b3ae5a592d70e00602e87a783535ffe967e-refs/branch-heads/2924@{#54}
OS: Mac (10.11.6, 10.12.1 )

Pre-condition: Allow 'Location' ,'Midi' and 'Camera' permission for https://permission.site such that its icon is seen within omnibox.

What steps will reproduce the problem?
1. Launch chrome and navigate to https://permission.site/
2. Click all the permission icons in the omnibox (refer video) and then click outside the omnibox such that bubble vanish.
3. Observe hover effect.

Actual:Hover effect stays on two of the permission icons within omnibox evenafter clicking outside omnibox.
Expected: Hover effect should not stay.

This is a regression issue, broken in 'M 56' and below is manual bisect info:

Good Build: 56.0.2919.0
Bad Build: 56.0.2920.0

Note: Issue is not seen on Windows and Linux OS.
Actual_site.mov
3.5 MB Download

Comment 1 by hdodda@chromium.org, Nov 22 2016

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision
Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build: 56.0.2919.0 (Revision:431801)
Bad Build: 56.0.2920.0 (Revision:432057)

You are probably looking for a change made after 431907 (known good), but no later than 431908 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/97bd029159326fcd0792045a451b99cf9b20c913..2edc6f9145d91684f2151462fa20873c29b87b62

From the CL above, assigning the issue to the concern owner 

@spqchan - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2478673002

Thanks!

Comment 2 by msrchandra@chromium.org, Nov 22 2016

Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 3 by spqc...@chromium.org, Nov 23 2016

Status: Started (was: Assigned)
This will be fixed by: https://codereview.chromium.org/2511043002/

Comment 4 by rbasuvula@chromium.org, Nov 28 2016

Cc: rbasuvula@chromium.org
Just for update, Still able to reproduce the issue on Mac 10.11.6 using latest chrome version 57.0.2935.0.

spqchan@ Could you please look into this issue.

Thanks!

Comment 5 by spqc...@chromium.org, Nov 28 2016 

The CL is still in review
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90af6b8cabfe002784be9735e4a1b675588b06f2

commit 90af6b8cabfe002784be9735e4a1b675588b06f2
Author: spqchan <spqchan@chromium.org>
Date: Wed Nov 30 19:22:58 2016

[Mac] Omnibox icons active states

Implemented OmniboxIconBubbleController for bubbles anchored to the omnibox
icons. This controller updates the icon's active state based on the state of the
bubble.

This CL affect the following bubbles:
- Translate
- Permission
- Content settings
- Bookmarks
- Manage passwords

Other bubbles will be update in a follow up CL

BUG= 588377 ,  667707 

Review-Url: https://codereview.chromium.org/2511043002
Cr-Commit-Position: refs/heads/master@{#435370}

[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
[add] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/omnibox_decoration_bubble_controller.h
[add] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/omnibox_decoration_bubble_controller.mm
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.h
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/translate/translate_bubble_controller.h
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h
[modify] https://crrev.com/90af6b8cabfe002784be9735e4a1b675588b06f2/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

Comment 7 by spqc...@chromium.org, Nov 30 2016

Labels: Merge-Request-56

Comment 8 by dimu@chromium.org, Dec 1 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 1 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980

commit 44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980
Author: spqchan <spqchan@chromium.org>
Date: Thu Dec 01 18:54:18 2016

[Mac] Omnibox icons active states

Implemented OmniboxIconBubbleController for bubbles anchored to the omnibox
icons. This controller updates the icon's active state based on the state of the
bubble.

This CL affect the following bubbles:
- Translate
- Permission
- Content settings
- Bookmarks
- Manage passwords

Other bubbles will be update in a follow up CL

BUG= 588377 ,  667707 

Review-Url: https://codereview.chromium.org/2511043002
Cr-Commit-Position: refs/heads/master@{#435370}
(cherry picked from commit 90af6b8cabfe002784be9735e4a1b675588b06f2)

Review URL: https://codereview.chromium.org/2542173002 .

Cr-Commit-Position: refs/branch-heads/2924@{#254}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
[add] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/omnibox_decoration_bubble_controller.h
[add] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/omnibox_decoration_bubble_controller.mm
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.h
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/translate/translate_bubble_controller.h
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h
[modify] https://crrev.com/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

Comment 10 by spqc...@chromium.org, Dec 1 2016

Status: Fixed (was: Started)

Comment 11 by msrchandra@chromium.org, Dec 2 2016

Labels: TE-Verified-M56 TE-Verified-56.0.2924.14
Tested the issue on Latest Dev# 56.0.2924.14 on Mac OS X 10.11.1 and the issue is no more reproducible.
The focus in the omnibox is behaving accordingly. Hence adding TE-Verified Labels.
Attaching a screen cast for reference.
Thank You.
667707.mov
3.1 MB Download
►

Sign in to add a comment