New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667706 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Unwanted border line is seen sign in page and sign in overlay

Project Member Reported by sc00335...@techmahindra.com, Nov 22 2016

Issue description

Version: 56.0.2924.0 dev 
OS: Ubuntu 14.04,Windows

Pre-Condition: Enable Cross process frames for guests flag from chrome://flags

What steps will reproduce the problem?
(1)Launch chrome and go to chrome://chrome-signin/?access_point=0&reason=0 (or) Click on sign in link from chrome://apps and observe border of sign in overlay 

Expected: No unwanted border should be seen even on enabling that flag.
Actual: Instead unwanted borders are seen.

This is Non-regression issue as this behaviour is seen from introduction of Cross process frames for guests flag in 56.0.2924.0 build.

CL: https://chromium.googlesource.com/chromium/src/+log/56.0.2923.0..56.0.2924.0?pretty=fuller&n=10000

Suspecting  https://codereview.chromium.org/2508763002 from changelog.

@avallee: Please confirm the issue.

 
Attaching screenshots for reference..
Expected_border.png
121 KB View Download
Actual_border.png
118 KB View Download
Actual_sign in overlay.png
115 KB View Download
Expected_sign in overlay.png
136 KB View Download
Labels: OS-Mac
Confirming this issue able to reproduce on Mac OS 10.12 using chrome latest Dev #56.0.2924.0.
Status: Started (was: Assigned)
Cc: wjmaclean@chromium.org
Fix in https://codereview.chromium.org/2519423002/
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7f6481c802488892776672589f32ab5f39b57e7

commit c7f6481c802488892776672589f32ab5f39b57e7
Author: avallee <avallee@chromium.org>
Date: Tue Nov 22 15:48:00 2016

Remove unwanted <webview> border in OOPIF mode.

This has been around for quite a white. Set the shadow iframe border to
0.

BUG= 667706 

Review-Url: https://codereview.chromium.org/2519423002
Cr-Commit-Position: refs/heads/master@{#433871}

[modify] https://crrev.com/c7f6481c802488892776672589f32ab5f39b57e7/extensions/renderer/resources/guest_view/guest_view_iframe_container.js

Status: Fixed (was: Started)

Sign in to add a comment