New issue
Advanced search Search tips

Issue 667696 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
TT



Sign in to add a comment

Enable authpolicyd build and installation

Project Member Reported by tnagel@chromium.org, Nov 22 2016

Issue description

.
 

Comment 1 by tnagel@chromium.org, Nov 22 2016

Example use of board-specific IUSE flags: https://chromium-review.googlesource.com/#/c/293932/
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3472c1900afce4a4276682a94613e5f7b0e1d725

commit 3472c1900afce4a4276682a94613e5f7b0e1d725
Author: Lutz Justen <ljusten@chromium.org>
Date: Wed Nov 23 10:55:02 2016

Make authpolicy a dependency of Chrome

The authpolicy package handles authentication and policy fetch from Active
Directory servers. Since Chrome is the only package that talks to it, it is
added as a dependency of Chrome.

Authpolicy is disabled by default. During an initial testing phase it is planned
to be enabled on certain boards only.

BUG= chromium:667696 
TEST=Emerges, can be turned on via board-specific overlays

Change-Id: I32e1bb61e28fe4e35c29a64d48d0d479e472d0c9
Reviewed-on: https://chromium-review.googlesource.com/413985
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3472c1900afce4a4276682a94613e5f7b0e1d725/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Comment 4 by tnagel@chromium.org, Nov 24 2016

Labels: Enterprise-Triaged M-57
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/30f004edc1629904c51008f052efdb729be27053

commit 30f004edc1629904c51008f052efdb729be27053
Author: Lutz Justen <ljusten@chromium.org>
Date: Wed Nov 30 17:06:08 2016

Turn authpolicy on for everything except arm

Some dependencies don't compile on arm (yet). The original plan was to turn
authpolicy on for some boards only. However, we decided to turn it on
for all x86-based boards, so we hit problems rather sooner than later.

BUG= chromium:667696 
TEST=Used emerge to display dependencies, made sure logic for toggling works.

Change-Id: I4db46e503df117f029aa2ebc6dc5f4c8e321de19
Reviewed-on: https://chromium-review.googlesource.com/415324
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>

[modify] https://crrev.com/30f004edc1629904c51008f052efdb729be27053/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/63da1a3f6b03bb80835b878cebf8b6cbf8e6b363

commit 63da1a3f6b03bb80835b878cebf8b6cbf8e6b363
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Dec 08 20:02:26 2016

Add authpolicy dependency to target-chromium-os ebuild

This CL is a temp solution. The original plan was to enable the USE flag by
default in the chromeos-chrome ebuild, see CL:415324. However, this brought
down the PFQ twice since the change landed without actually being compiled
(it didn't uprev the ebuild) and later on broke the PFQ when an unrelated
change upreved Chrome. See chromium:672119 and chromium:670430 for details.
Adding the dependency in the target-chromium-os ebuild forces the change to
be picked up immediately. Once authpolicy builds and is stable, this CL is
reverted and the original plan is executed.

BUG= chromium:667696 
TEST=build_packages on x86-generic and amd64-generic

Change-Id: I6e151082790c15090b6963d5102846a67ee84db9
Reviewed-on: https://chromium-review.googlesource.com/418200
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/63da1a3f6b03bb80835b878cebf8b6cbf8e6b363/profiles/features/embedded/make.defaults
[modify] https://crrev.com/63da1a3f6b03bb80835b878cebf8b6cbf8e6b363/virtual/target-chromium-os/target-chromium-os-1.ebuild
[rename] https://crrev.com/63da1a3f6b03bb80835b878cebf8b6cbf8e6b363/virtual/target-chromium-os/target-chromium-os-1-r59.ebuild

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3b8a031cffe3badf87556f64858a7eacf093a042

commit 3b8a031cffe3badf87556f64858a7eacf093a042
Author: Lutz Justen <ljusten@chromium.org>
Date: Wed Dec 14 13:11:18 2016

Turn authpolicy on by default for Chrome, mask it out for arm

Some dependencies don't compile on arm (yet). The original plan was to turn
authpolicy on for some boards only. However, we decided to turn it on
for all x86-based boards, so we hit problems rather sooner than later.

This is basically a reland of CL:416049 and CL:415730.

BUG= chromium:667696 
TEST=Used emerge to display dependencies, made sure logic for toggling works.

Change-Id: I26dc740ab9262405f1ea4d937c6eac6bb97e62ac
Reviewed-on: https://chromium-review.googlesource.com/419436
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3b8a031cffe3badf87556f64858a7eacf093a042/profiles/arch/arm/package.use.mask
[modify] https://crrev.com/3b8a031cffe3badf87556f64858a7eacf093a042/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5c2f613a77bdb473b7608eb3d771d2efbe19f942

commit 5c2f613a77bdb473b7608eb3d771d2efbe19f942
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Dec 15 19:23:18 2016

Revert "Add authpolicy dependency to target-chromium-os ebuild"

This reverts 63da1a3f6b03bb80835b878cebf8b6cbf8e6b363 (except for
target-chromium-os-1-r59.ebuild, which is uprev'ed instead of
reverted/downrev'ed).

The above CL was temp. With CL:419436 the actual implementation has
landed.

BUG= chromium:667696 
TEST=build_packages on x86-generic and amd64-generic

Change-Id: I210ca71bc98c56758b179cf292a90e89c8a757cb
Reviewed-on: https://chromium-review.googlesource.com/420986
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/5c2f613a77bdb473b7608eb3d771d2efbe19f942/profiles/features/embedded/make.defaults
[modify] https://crrev.com/5c2f613a77bdb473b7608eb3d771d2efbe19f942/virtual/target-chromium-os/target-chromium-os-1.ebuild
[rename] https://crrev.com/5c2f613a77bdb473b7608eb3d771d2efbe19f942/virtual/target-chromium-os/target-chromium-os-1-r60.ebuild

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment