IOS beta compilation broken |
||||||
Issue descriptionhttps://codereview.chromium.org/2512653003/ was not included in the branch.
,
Nov 22 2016
https://chromereviews.googleplex.com/546977013/ is also missing
,
Nov 23 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 23 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/50e764202fc86d858869c8dded7ceeff7a4e6bad commit 50e764202fc86d858869c8dded7ceeff7a4e6bad Author: olivierrobin <olivierrobin@google.com> Date: Wed Nov 23 08:41:18 2016
,
Nov 23 2016
this two issues are solved, but there is another error
[1291/16274] OBJCXX obj/ios_internal/chrome/browser/web/web/error_page_content.o
FAILED: obj/ios_internal/chrome/browser/web/web/error_page_content.o
/b/build/slave/cache/cipd/goma/gomacc clang++ -MMD -MF obj/ios_internal/chrome/browser/web/web/error_page_content.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DDISABLE_NACL -DENABLE_RLZ -DUSE_PROPRIETARY_CODECS -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=284979-2 -DCR_XCODE_VERSION=0800 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_BUILD_NO_OPTS -DSK_SUPPORT_GPU=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen -I../../third_party/libwebp -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -Igen/components -Igen/components -Igen/components/strings -Igen/components/strings -Igen/components/strings -Igen/components/strings -I../../ios_internal/third_party/material_components_ios/src/components/AppBar/src -I../../ios_internal/third_party/material_components_ios/src/components/ActivityIndicator/src -I../../ios_internal/third_party/material_components_ios/src/components/ButtonBar/src -I../../ios_internal/third_party/material_components_ios/src/components/Buttons/src -I../../ios_internal/third_party/material_components_ios/src/components/CollectionCells/src -I../../ios_internal/third_party/material_components_ios/src/components/CollectionLayoutAttributes/src -I../../ios_internal/third_party/material_components_ios/src/components/Collections/src -I../../ios_internal/third_party/material_components_ios/src/components/Dialogs/src -I../../ios_internal/third_party/material_components_ios/src/components/FlexibleHeader/src -I../../ios_internal/third_party/material_components_ios/src/components/FontDiskLoader/src -I../../ios_internal/third_party/material_components_ios/src/components/HeaderStackView/src -I../../ios_internal/third_party/material_components_ios/src/components/Ink/src -I../../ios_internal/third_party/material_components_ios/src/components/NavigationBar/src -I../../ios_internal/third_party/material_components_ios/src/components/OverlayWindow/src -I../../ios_internal/third_party/material_components_ios/src/components/Palettes/src -I../../ios_internal/third_party/material_components_ios/src/components/ProgressView/src -I../../ios_internal/third_party/material_components_ios/src/components/RobotoFontLoader/src -I../../ios_internal/third_party/material_components_ios/src/components/ShadowElevations/src -I../../ios_internal/third_party/material_components_ios/src/components/ShadowLayer/src -I../../ios_internal/third_party/material_components_ios/src/components/Snackbar/src -I../../ios_internal/third_party/material_components_ios/src/components/SpritedAnimationView/src -I../../ios_internal/third_party/material_components_ios/src/components/Switch/src -I../../ios_internal/third_party/material_components_ios/src/components/Typography/src -I../../third_party/boringssl/src/include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fcolor-diagnostics -arch arm64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Os -gdwarf-2 -isysroot /Applications/Xcode8.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.0.sdk -stdlib=libc++ -miphoneos-version-min=9.0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-rtti -fno-exceptions -c ../../ios_internal/chrome/browser/web/error_page_content.mm -o obj/ios_internal/chrome/browser/web/web/error_page_content.o
../../ios_internal/chrome/browser/web/error_page_content.mm:69:29: error: too few arguments to function call, expected 10, have 9
nullptr, &errorStrings);
^
../../components/error_page/common/localized_error.h:27:3: note: 'GetStrings' declared here
static void GetStrings(int error_code,
^
1 error generated.
,
Nov 23 2016
Assigning to sheriff. This is likely a roll issue. We branched on Thursday at a point where autoroller was broken. So the fix must already be on trunk.
,
Nov 23 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/92d6af1be55414389626c50a18216b80f9689c59 commit 92d6af1be55414389626c50a18216b80f9689c59 Author: chrome-bot <chrome-bot@chromium.org> Date: Wed Nov 23 13:33:52 2016
,
Nov 23 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by olivierrobin@chromium.org
, Nov 22 2016