New issue
Advanced search Search tips

Issue 667685 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 668590

Blocking:
issue 667575



Sign in to add a comment

hasEditableLevel should not be entered during style recalculation

Project Member Reported by xiaoche...@chromium.org, Nov 22 2016

Issue description

We should not call hasEditableLevel during style recalculation, as hasEditableLevel relies on clean style. We should find all such code paths and eliminate them.
 
Cc: yoichio@chromium.org yosin@chromium.org e...@chromium.org
Components: Blink>Editing
Labels: -Pri-2 Pri-3
Owner: xiaoche...@chromium.org
Status: Assigned (was: Untriaged)
A typical stack trace of entering the function in style recalc looks like:

STDERR: #2 0x7fb28ea3803c blink::hasEditableLevel()
STDERR: #3 0x7fb28ea37f07 blink::hasEditableStyle()
STDERR: #4 0x7fb28ea382a5 blink::isRootEditableElement()
STDERR: #5 0x7fb28e8a59d7 blink::Element::supportsFocus()
STDERR: #6 0x7fb28ced9088 blink::AXNodeObject::canSetFocusAttribute()
...
STDERR: #35 0x7fb28cefb25f blink::AXObjectCacheImpl::textChanged()
STDERR: #36 0x7fb28f285d41 blink::LayoutText::setText()
...
STDERR: #52 0x7fb28e8a201f blink::Element::rebuildLayoutTree()
STDERR: #53 0x7fb28e8a11d3 blink::Element::recalcOwnStyle()
STDERR: #54 0x7fb28e8a08df blink::Element::recalcStyle()
STDERR: #55 0x7fb28e8273a5 blink::Document::updateStyle()

We need to wait until the LayoutNG project decouples style update with layout update. At the current stage, we have to allow entering hasEditableLevel during style recalc. We will retry when the decoupling is done.
Blockedon: 668590
Status: WontFix (was: Assigned)
WontFix as we are going to deprecate -webkit-use-modify instead.

Sign in to add a comment