New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667671 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 671375



Sign in to add a comment

Not resetting scroll position when navigating to "About"

Reported by jshan...@etouch.net, Nov 22 2016

Issue description

Chrome Version:56.0.2924.3 (Official Build) 66f73b3ae5a592d70e00602e87a783535ffe967e-refs/branch-heads/2924@{#54}
OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS)

Steps:
1. Launch Chrome and navigate to chrome://md-settings
2. Zoom more than 150% or 250% (using 'Ctrl' '+') and scroll down the page.
3. Now Click on 'Main menu' icon, select 'About chrome' and observe.

Actual: 'About chrome' page is not navigated properly i.e it is seen auto scrolled down

Expected: 'About chrome' page should be navigated properly.

This is a regression issue broken in M-55 series, will soon update the bisect info.

Good build: 55.0.2876.0
Bad build: 55.0.2878.0


 
Actual_video.mp4
672 KB View Download
Expected_video.mp4
435 KB View Download

Comment 1 by hdodda@chromium.org, Nov 22 2016

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision
Owner: skobes@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2876.0 (Revision:421986)
Bad build: 55.0.2878.0 (Revision:422326)

You are probably looking for a change made after 422201 (known good), but no later than 422202 (first known bad).
CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/6403abd0235a72f80ddfd588b3e9bfe4918e497c..20166be8458e48f27382ef6d4fd0679cfccf9361

From the CL above, assigning the issue to the concern owner 

@skobes - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2349943002

Thanks!

Comment 2 by skobes@chromium.org, Nov 23 2016

Owner: dbeam@chromium.org
This bug is not correlated with scroll anchoring (repros with scroll anchoring disabled in about:flags), so it is not related to the change mentioned in #1.

I am not sure it is a regression either, as I can repro in stable (54.0.2840.99), though not consistently.

Assuming the "About chrome" link is triggering a client-side navigation I would expect the MD Settings javascript to reset the scroll position.

@dbeam can you take a look or reroute as appropriate?  Feel free to kick it back to me if you think Blink scrolling code is doing the wrong thing here.
Just to to update the latest behavior of the bug, Issue is still observed on windows 10 chrome latest canaray M57-57.0.2938.0

dbeam@ Could you please let us know is there any recent update available on this issue?

Thanks!
Just to update the latest behavior of the bug, Issue is still observed on chrome latest Dev M57-57.0.2944.0
dbeam@ Could you please let us know is there any recent update available on this issue?

Thanks!

Blocking: 671375
Labels: Hotlist-MD-Settings-Navigation OS-Chrome
Summary: Not resetting scroll position when navigating to "About" (was: Regression: 'About chrome' page is not navigated properly after selecting it from Main menu.)
This occurs regardless of zoom level. Repro:
1) Change browser height so that About page scrolls
2) Go to chrome://md-settings and scroll partially
3) Change to About page via sidenav

Seems like we just aren't resetting scroll when switching to the About page.

Comment 6 by dbeam@chromium.org, Jan 12 2017

Cc: dbeam@chromium.org
Owner: tommycli@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52d38e7a5ae31b750d87205b072a324cf99926ef

commit 52d38e7a5ae31b750d87205b072a324cf99926ef
Author: tommycli <tommycli@chromium.org>
Date: Wed Jan 18 01:03:36 2017

MD Settings: Scroll to top when navigating to About page.

BUG= 667671 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2627403003
Cr-Commit-Position: refs/heads/master@{#444217}

[modify] https://crrev.com/52d38e7a5ae31b750d87205b072a324cf99926ef/chrome/browser/resources/settings/settings_page/main_page_behavior.js
[modify] https://crrev.com/52d38e7a5ae31b750d87205b072a324cf99926ef/chrome/test/data/webui/settings/basic_page_browsertest.js

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on Chrome OS 9202.1.0, 57.0.2987.6

Sign in to add a comment