New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667650 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

The opt-in menu turns to blank if switch ime by shortcuts

Project Member Reported by xiulingw@chromium.org, Nov 22 2016

Issue description

Version 57.0.2926.0 canary 
Platform 9011 link
Firmware Google_Link.2695.1.169

REPRO STEPS 
1.Checked <Show input options in the shelf> 
2.Open opt-in menu in shelf 
3.Press Ctrl+Shift+Space

ACTUAL RESULTS 
The opt-in menu turns to blank.
 
Screenshot 2016-11-22 at 2.46.09 PM.png
120 KB View Download
Summary: The opt-in menu turns to blank if switch ime by shortcuts (was: The opt-in menu turns to blank if switch ime by Ctrl+Shift+Space)
Also repro when press Ctrl+Space in step#3.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29b403dc3d47bb52477c4bf5324b46557d38cd38

commit 29b403dc3d47bb52477c4bf5324b46557d38cd38
Author: azurewei <azurewei@chromium.org>
Date: Thu Dec 08 03:40:00 2016

Set ImeListView's scrollable range when updating

For material design, we need to set turns the scroll view (listing all current IMEs) into a bounded scroll view, with a fixed height. When switching IME, this needs to set again and then call Layout() & SchedulePaint().
Since the range should not change during switching IMEs, we pass the range in the constructor of ImeListView instead of ImeListView::Update() every time.

BUG= 667650 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2541743004
Cr-Commit-Position: refs/heads/master@{#437168}

[modify] https://crrev.com/29b403dc3d47bb52477c4bf5324b46557d38cd38/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc

Labels: Merge-Request-56
Labels: Merge-Approved-56
Labels: -M-57 M-56
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 9 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7aa909d446a230ad7f3acf9667b61cadbebbe83

commit a7aa909d446a230ad7f3acf9667b61cadbebbe83
Author: azurewei <azurewei@chromium.org>
Date: Fri Dec 09 01:06:32 2016

Set ImeListView's scrollable range when updating

For material design, we need to set turns the scroll view (listing all current IMEs) into a bounded scroll view, with a fixed height. When switching IME, this needs to set again and then call Layout() & SchedulePaint().
Since the range should not change during switching IMEs, we pass the range in the constructor of ImeListView instead of ImeListView::Update() every time.

TBR=tdanderson@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG= 667650 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2541743004
Cr-Commit-Position: refs/heads/master@{#437168}
(cherry picked from commit 29b403dc3d47bb52477c4bf5324b46557d38cd38)

Review-Url: https://codereview.chromium.org/2555303005
Cr-Commit-Position: refs/branch-heads/2924@{#421}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/a7aa909d446a230ad7f3acf9667b61cadbebbe83/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc

Status: Fixed (was: Assigned)

Comment 8 by dimu@chromium.org, Dec 9 2016

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.
Status: Verified (was: Fixed)
Verified in M57 9090 clapper ,
Input tools 6.6.9.1

Sign in to add a comment