New issue
Advanced search Search tips

Issue 667623 link

Starred by 1 user
Status: Fixed
Owner:
tapted@chromium.org
Closed: Nov 2016
Cc:
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

MacViews: Bubble border is too dark with chrome://flags/#secondary-ui-md

Project Member Reported by tapted@chromium.org, Nov 22 2016 
Chrome Version       : 56.0.2914.3
OS Version: OS X 10.12.1

Enable MacViews dialogs + harmony. Show the bookmark bubble.

The border is too dark.

On Mac we should just get the Window Server to draw our shadow - it does a decent job.

Fix: https://codereview.chromium.org/2519313002
actual.png
18.3 KB View Download
expected.png
18.0 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf9bf4f69ef97afe4554e489704940db643dac35

commit bf9bf4f69ef97afe4554e489704940db643dac35
Author: tapted <tapted@chromium.org>
Date: Wed Nov 23 01:22:24 2016

MacViews: For "NO_ASSET" MD bubbles, just use the border drawn by the window server.

BubbleBorder::PaintMd() currently ignores BubbleBorder::shadow_. That's
fine for everything except BubbleBorder::NO_ASSETS which should never
draw borders or shadows. On Mac, it allows the WindowServer to provide
the shadow instead.

Add BubbleBorder::PaintNoAssets() which just paints transparent pixels
around the edge of the bubble. This ensures that subviews painting over
the bubble corners (such as the signin promo on the bookmark bubble) get
rounded (again).

BubbleBorder::NO_ASSETS is also used by the fullscreen bubble and shelf
tooltips on ChromeOS. This approach keeps those bubbles to spec with
--secondary-ui-md (e.g. per http://crbug.com/595011 ).

BUG= 667623 ,  660018 

Review-Url: https://codereview.chromium.org/2519313002
Cr-Commit-Position: refs/heads/master@{#434069}

[modify] https://crrev.com/bf9bf4f69ef97afe4554e489704940db643dac35/ui/views/bubble/bubble_border.cc
[modify] https://crrev.com/bf9bf4f69ef97afe4554e489704940db643dac35/ui/views/bubble/bubble_border.h

Comment 2 by tapted@chromium.org, Nov 23 2016

Status: Fixed (was: Started)
►

Sign in to add a comment