New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667608 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Allow to create ARC++ windows minimized on startup.

Project Member Reported by mtomasz@chromium.org, Nov 22 2016

Issue description

Activity#moveToBack may be called before the window is created. As a result a window would be shown unexpectedly.

Chrome side for b/31012717.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43961ed73ccb8a76e6621fcdbe0a930aa88a42b3

commit 43961ed73ccb8a76e6621fcdbe0a930aa88a42b3
Author: mtomasz <mtomasz@chromium.org>
Date: Tue Nov 22 09:25:50 2016

Allow to create ARC++ windows minimized on startup.

TEST=Tested with OneNote badge.
BUG= 667608 

Review-Url: https://codereview.chromium.org/2517833003
Cr-Commit-Position: refs/heads/master@{#433824}

[modify] https://crrev.com/43961ed73ccb8a76e6621fcdbe0a930aa88a42b3/components/exo/shell_surface.cc
[modify] https://crrev.com/43961ed73ccb8a76e6621fcdbe0a930aa88a42b3/components/exo/shell_surface_unittest.cc

Comment 2 by skuhne@chromium.org, Nov 22 2016

Labels: Merge-Request-56

Comment 3 by dimu@chromium.org, Nov 23 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 24 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be582ec0cd5e08cf982b5827b31da3965c980411

commit be582ec0cd5e08cf982b5827b31da3965c980411
Author: Tomasz Mikolajewski <mtomasz@chromium.org>
Date: Thu Nov 24 00:54:57 2016

Allow to create ARC++ windows minimized on startup.

TEST=Tested with OneNote badge.
BUG= 667608 

Review-Url: https://codereview.chromium.org/2517833003
Cr-Commit-Position: refs/heads/master@{#433824}
(cherry picked from commit 43961ed73ccb8a76e6621fcdbe0a930aa88a42b3)

Review URL: https://codereview.chromium.org/2525183002 .

Cr-Commit-Position: refs/branch-heads/2924@{#87}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/be582ec0cd5e08cf982b5827b31da3965c980411/components/exo/shell_surface.cc
[modify] https://crrev.com/be582ec0cd5e08cf982b5827b31da3965c980411/components/exo/shell_surface_unittest.cc

Components: Platform>ARC
Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbef4b39c24bd1a94e3b66158a20af4b607f5090

commit bbef4b39c24bd1a94e3b66158a20af4b607f5090
Author: mtomasz <mtomasz@chromium.org>
Date: Mon Nov 28 09:10:52 2016

Cleanup tests for minimizing ARC++ windows on startup.

Follow up for: https://codereview.chromium.org/2517833003/

TEST=exo_unittests
BUG= 667608 

Review-Url: https://codereview.chromium.org/2530443003
Cr-Commit-Position: refs/heads/master@{#434622}

[modify] https://crrev.com/bbef4b39c24bd1a94e3b66158a20af4b607f5090/components/exo/shell_surface_unittest.cc

Project Member

Comment 8 by sheriffbot@chromium.org, Jan 9 2017

Labels: -Merge-TBD

Sign in to add a comment