New issue
Advanced search Search tips

Issue 667583 link

Starred by 1 user
Status: Fixed
Owner:
rdevlin....@chromium.org
Closed: Dec 2016
Cc:
lazyboy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Extensions renderer code has extra tab ids floating around

Project Member Reported by rdevlin....@chromium.org, Nov 22 2016 
Extensions renderer code needs to know about the tab id for a few reasons - primarily tab-specific permissions. However, we should be able to remove the tab id from the request sender (it can get it from the ExtensionFrameHelper).  As a result of this, we should also be able to remove it from a lot of the messaging code.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c97b791906cf18bb1d5232ba881287db9898cd84

commit c97b791906cf18bb1d5232ba881287db9898cd84
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Tue Nov 22 19:50:26 2016

[Extensions] Remove RequestSender::ScopedTabID

Remove RequestSender::ScopedTabID.  This was used to set the tab id, and
then passed to the browser in the request params for the API call, but
a) Was only set in a response to ExtensionMsg_DeliverMessage (?) and
b) The tab id can (and should) be obtained from the ExtensionFrameHelper

Ideally, we'll also remove the tab id from the request params entirely,
but this is a decent start.

It also helps remove a blocker for extension bindings.

BUG= 667583 
BUG= 653596 

Review-Url: https://codereview.chromium.org/2517393002
Cr-Commit-Position: refs/heads/master@{#433948}

[modify] https://crrev.com/c97b791906cf18bb1d5232ba881287db9898cd84/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/c97b791906cf18bb1d5232ba881287db9898cd84/extensions/renderer/request_sender.cc
[modify] https://crrev.com/c97b791906cf18bb1d5232ba881287db9898cd84/extensions/renderer/request_sender.h

Comment 2 by rdevlin....@chromium.org, Dec 2 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment