Issue metadata
Sign in to add a comment
|
Regressing again: Android accessibility getting stuck after closing SELECT element pop-up |
||||||||||||||||||||||||
Issue descriptionSee http://crbug.com/652805 for the last time this happened. Bisect Range https://chromium.googlesource.com/chromium/src/+log/56.0.2899.0..56.0.2900.0?pretty=fuller&n=10000 56.0.2884.0 - Good 56.0.2891.12 - Good 56.0.2895.3 - Good 56.0.2898.0 - Good 56.0.2899.0 - Good 56.0.2900.0 - Bad 56.0.2913.5 - Bad 56.0.2919.3 - Bad Working fine on Beta 55.0.2883.53 and previous beta 55.0.2883.45
,
Nov 29 2016
dmazzoni@, we need this fixed and merged back to the M56 branch by next Monday (preferably sooner), how are things looking?
,
Dec 2 2016
The bad change was https://chromiumcodereview.appspot.com/2416293002. I'm reverting it on trunk now: https://codereview.chromium.org/2547903002/ OK to merge the revert to the M56 branch as soon as it lands on trunk?
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2607397665f0a0a8e3b16198dbeaae2a9e1e0bb commit c2607397665f0a0a8e3b16198dbeaae2a9e1e0bb Author: dmazzoni <dmazzoni@chromium.org> Date: Fri Dec 02 17:29:25 2016 Revert "Android shouldn't fire focus events when the WebView itself isn't focused" Caused http://crbug.com/667559 - when clicking on a <select> pop-up and then returning to the page, focus was being reset to the whole page rather than back to the select element. Original changelist: https://chromiumcodereview.appspot.com/2416293002 BUG= 648391 , 667559 TBR=dtseng@chromium.org Review-Url: https://codereview.chromium.org/2547903002 Cr-Commit-Position: refs/heads/master@{#435964} [modify] https://crrev.com/c2607397665f0a0a8e3b16198dbeaae2a9e1e0bb/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
,
Dec 2 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 2 2016
Merging now.
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fa77424b02d63b38bb1262471cc4af8e3f54fc0 commit 7fa77424b02d63b38bb1262471cc4af8e3f54fc0 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Fri Dec 02 20:05:14 2016 Merge to M56: Revert "Android shouldn't fire focus events when the WebView itself isn't focused" Caused http://crbug.com/667559 - when clicking on a <select> pop-up and then returning to the page, focus was being reset to the whole page rather than back to the select element. Original changelist: https://chromiumcodereview.appspot.com/2416293002 BUG= 648391 , 667559 TBR=dtseng@chromium.org Review-Url: https://codereview.chromium.org/2547903002 Cr-Commit-Position: refs/heads/master@{#435964} (cherry picked from commit c2607397665f0a0a8e3b16198dbeaae2a9e1e0bb) Review URL: https://codereview.chromium.org/2546183002 . Cr-Commit-Position: refs/branch-heads/2924@{#296} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/7fa77424b02d63b38bb1262471cc4af8e3f54fc0/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
,
Dec 5 2016
Marking as fixed given the reverts have landed on trunk and M56 branch, please reopen if further work is required.
,
Dec 6 2016
Verified in latest M56(56.0.2924.17) and M57 (57.0.2942.0) On Nexus 6P (NMF26R) and Pixel(NMF26R)
,
Dec 7 2016
Verified in M56.0.2924.18 on Samsung S6(MMB29M) and Nexus 6P(NMF26R) |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dmazz...@chromium.org
, Nov 22 2016