New issue
Advanced search Search tips

Issue 667552 link

Starred by 1 user
Status: Fixed
Owner:
mek@chromium.org
Closed: Dec 2016
Cc:
jbroman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Layout Test broadcastchannel/blobs.html is flaky

Project Member Reported by mek@chromium.org, Nov 22 2016 
The following layout test is flaky on all platforms.

broadcastchannel/blobs.html

Probable cause:

Mojo ordering is even more mysterious than I thought, causing a message sent over BroadcastChannel forwarded back over regular postMessage to arrive before the same message over just the BroadcastChannel arrives.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55e6c2a1b1892268ca20d1c059638228d2a9c349

commit 55e6c2a1b1892268ca20d1c059638228d2a9c349
Author: mek <mek@chromium.org>
Date: Tue Nov 22 18:32:50 2016

Fix flakyness in broadcastchannel/blobs.html test.

Due to lack of ordering guarantees in mojo, the "done" message send on the
BroadcastChannel could arrive after the worker signals that it was done
(the worker sending that message via a MessagePort).

Fortunately the spec doesn't give any guarantees of relative ordering of
messages on message ports and other events, so this is all perfectly spec
compliant (if not a little bit confusing), so this just changes the test to
wait for both "done" signals to arrive before verifying the results.

BUG= 667552 

Review-Url: https://codereview.chromium.org/2521843002
Cr-Commit-Position: refs/heads/master@{#433920}

[modify] https://crrev.com/55e6c2a1b1892268ca20d1c059638228d2a9c349/third_party/WebKit/LayoutTests/broadcastchannel/blobs.html

Comment 2 by mek@chromium.org, Dec 6 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment