Issue 667547 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	█ nainar@chromium.org Not on Chrome anymore
Closed:	Feb 2017
Cc:	█ gozzard@google.com █ meade@chromium.org thestig@chromium.org skau@chromium.org rbpotter@chromium.org style-bugs@google.com
Components:	Blink>CSS
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Feature
Update-Monthly

PrintBrowser

Project Member Reported by nainar@chromium.org, Nov 22 2016

Issue description

Feature description:

This project enables user to run Chrome and view all websites as if they were in Print Preview mode. 

owner: gozzard@google.com
Intern host: nainar@chromium.org

Design doc forthcoming

Marking myself as owner since my intern is not a project member.

Feature description:

This project enables user to run Chrome and view all websites as if they were in Print Preview mode. 

owner: gozzard@google.com
Intern host: nainar@chromium.org

Design Doc: https://docs.google.com/a/google.com/document/d/1pRu5Lh4SGelhbsqfrLnLQov0o82nVmoWbucz1LYZtu8/edit?usp=sharing

Marking myself as owner since my intern is not a project member.

Feature description:

This project enables user to run Chrome and view all websites as if they were in Print Preview mode. 

owner: gozzard@google.com
Intern host: nainar@chromium.org

Design Doc: https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4ww/edit?usp=sharing

Marking myself as owner since my intern is not a project member.

Feature description:

This project enables user to run Chrome and view all websites as if they were in Print Preview mode. 

owner: gozzard@google.com
Intern host: nainar@chromium.org

Design Doc: https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4ww/edit?usp=sharing

Marking myself as owner since my intern is not a project member.

Comment 1 by vitalyb...@chromium.org, Dec 12 2016

Cc: thestig@chromium.org rbpotter@chromium.org

Comment 2 by vitalyb...@chromium.org, Dec 12 2016

Cc: skau@chromium.org

Comment 3 by gozzard@google.com, Dec 15 2016

Description: Show this description

Comment 4 by skau@chromium.org, Dec 15 2016

It looks like you're adopting the viewer from print preview for this?  Does this mean that we're rendering PDFs and displaying them or redirecting the render back to the webframe?

It's not clear (to me) in the design doc.

Comment 5 by gozzard@google.com, Jan 25 2017

Description: Show this description

Comment 6 Deleted

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/080936f5193590e65409c60127a510f71e910d73

commit 080936f5193590e65409c60127a510f71e910d73
Author: gozzard <gozzard@google.com>
Date: Fri Feb 10 10:59:01 2017

Implements PrintBrowser mode.

Added --enable-print-browser runtime flag.

Renders the frame in print mode in response to the enable-print-browser
runtime flag.
Currently defaults to dimensions of A4 portrait paper and is set to show
background graphics.
This functionality is dependent on slimming paint v2, which is
automatically enabled if needed.

This can be invoked from the command line with:
content_shell --enable-print-browser "http://example.com"

The virtual test environment can be run using:
run-webkit-tests virtual/print_browser

Design doc: https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4ww/edit?usp=sharing
BUG= 667547 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2672983003
Cr-Commit-Position: refs/heads/master@{#449585}

[modify] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/content/child/runtime_features.cc
[modify] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/content/public/common/content_switches.cc
[modify] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/content/public/common/content_switches.h
[modify] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/third_party/WebKit/LayoutTests/print_testharness/README.txt
[add] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/third_party/WebKit/LayoutTests/virtual/print_browser/print_testharness/README.txt
[add] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/third_party/WebKit/LayoutTests/virtual/print_browser/print_testharness/test_enable_print_browser.html
[modify] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
[modify] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/080936f5193590e65409c60127a510f71e910d73/third_party/WebKit/public/web/WebRuntimeFeatures.h