New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667529 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Duplicate icons in case Chrome recovered from crash.

Project Member Reported by khmel@chromium.org, Nov 21 2016

Issue description

Inner bug: b/32765086

App launcher duplicates in case of Chrome is recovered from crash.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e1e8774f3b147906917dbd4e50f30bfc7372ba6

commit 4e1e8774f3b147906917dbd4e50f30bfc7372ba6
Author: khmel <khmel@chromium.org>
Date: Tue Nov 22 21:13:33 2016

arc: Fix duplicate icons in app launcher in case of crash.

This CL initializes tracking items by existing app set on start in
order to prevent race condition that leads to arc app created is
called twice for some apps.

TBR=xiyuan@chromium.org

TEST=Extended unit_tests
TEST=Manually on device with chrome://inducebrowsercrashforrealz
BUG=b/32765086
BUG= 667529 

Review-Url: https://codereview.chromium.org/2520173002
Cr-Commit-Position: refs/heads/master@{#433980}

[modify] https://crrev.com/4e1e8774f3b147906917dbd4e50f30bfc7372ba6/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/4e1e8774f3b147906917dbd4e50f30bfc7372ba6/chrome/browser/ui/app_list/arc/arc_app_test.cc
[modify] https://crrev.com/4e1e8774f3b147906917dbd4e50f30bfc7372ba6/chrome/browser/ui/app_list/arc/arc_app_test.h
[modify] https://crrev.com/4e1e8774f3b147906917dbd4e50f30bfc7372ba6/chrome/browser/ui/app_list/arc/arc_app_unittest.cc

Comment 2 by dimu@chromium.org, Nov 28 2016

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.

Comment 3 by khmel@chromium.org, Nov 30 2016

CL http://crrev.com/2545533002 is ready for merge (tested locally on device).

Bernie, could you please confirm the merge request?
Labels: -Merge-Review-56 Merge-Approved-56

Comment 5 by khmel@chromium.org, Nov 30 2016

Labels: -Hotlist-Merge-Review -Merge-Approved-56 Merge-Merged
Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 30 2016

Labels: merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/107cb37d3dd8af5acfb2c7f024b8b98bb80804da

commit 107cb37d3dd8af5acfb2c7f024b8b98bb80804da
Author: khmel <khmel@chromium.org>
Date: Wed Nov 30 19:20:05 2016

[Merge-M56] arc: Fix duplicate icons in app launcher in case of crash.

This CL initializes tracking items by existing app set on start in
order to prevent race condition that leads to arc app created is
called twice for some apps.

TBR=xiyuan@chromium.org
NOTRY=true
NOPRESUBMIT=true

TEST=Extended unit_tests
TEST=Manually on device with chrome://inducebrowsercrashforrealz
BUG=b/32765086
BUG= 667529 

Review-Url: https://codereview.chromium.org/2520173002
Cr-Commit-Position: refs/heads/master@{#433980}
(cherry picked from commit 4e1e8774f3b147906917dbd4e50f30bfc7372ba6)

Review-Url: https://codereview.chromium.org/2545533002
Cr-Commit-Position: refs/branch-heads/2924@{#202}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/107cb37d3dd8af5acfb2c7f024b8b98bb80804da/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/107cb37d3dd8af5acfb2c7f024b8b98bb80804da/chrome/browser/ui/app_list/arc/arc_app_test.cc
[modify] https://crrev.com/107cb37d3dd8af5acfb2c7f024b8b98bb80804da/chrome/browser/ui/app_list/arc/arc_app_test.h
[modify] https://crrev.com/107cb37d3dd8af5acfb2c7f024b8b98bb80804da/chrome/browser/ui/app_list/arc/arc_app_unittest.cc

Status: Verified (was: Fixed)
Verified on ChromeOS 9000.18.0, 56.0.2924.17

Sign in to add a comment