Issue metadata
Sign in to add a comment
|
Clicking Esc in Overview mode leaves all windows semi transparent |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 56.0.2923.0 (Official Build) dev (64-bit) Revision 0 Platform 9000.0.0 (Official Build) dev-channel peppy What steps will reproduce the problem? 1. Press F5 to switch to overview mode 2. Type any key to search 3. Press Esc key What happens instead? All windows become semi transparent
,
Nov 21 2016
,
Nov 22 2016
oshima@, can you please take a look and see if this CL (https://codereview.chromium.org/2470343003/) broke it. I think ScopedTransformOverviewWindow::ShowWindowOnExit() was previously restoring opacity on exit (which is dropped when text filter is used for non-matching windows) and I suspect this is not happening in the new code path.
,
Nov 22 2016
Not seeing the problem in 56.0.2920.0 (dev channel on samus). Seeing this in ToT (57.0.2927.0 r433469).
,
Nov 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/355b36934b8f321a7970679f9a13fa8768a1c384 commit 355b36934b8f321a7970679f9a13fa8768a1c384 Author: oshima <oshima@chromium.org> Date: Tue Nov 22 23:52:22 2016 Restore original opacity when exiting overview BUG= 667526 R=varkha@chromium.org TEST=Updated WindowSelectorTest.BasicTextFiltering Review-Url: https://codereview.chromium.org/2525753002 Cr-Commit-Position: refs/heads/master@{#434025} [modify] https://crrev.com/355b36934b8f321a7970679f9a13fa8768a1c384/ash/common/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/355b36934b8f321a7970679f9a13fa8768a1c384/ash/common/wm/overview/scoped_transform_overview_window.h [modify] https://crrev.com/355b36934b8f321a7970679f9a13fa8768a1c384/ash/wm/overview/window_selector_unittest.cc
,
Nov 23 2016
,
Nov 23 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/744ccc2c04a0811aeb9789e2fc9ad6fe5ae82a6b commit 744ccc2c04a0811aeb9789e2fc9ad6fe5ae82a6b Author: Mitsuru Oshima <oshima@chromium.org> Date: Mon Nov 28 21:56:43 2016 Restore original opacity when exiting overview BUG= 667526 R=varkha@chromium.org TEST=Updated WindowSelectorTest.BasicTextFiltering Review-Url: https://codereview.chromium.org/2525753002 Cr-Commit-Position: refs/heads/master@{#434025} (cherry picked from commit 355b36934b8f321a7970679f9a13fa8768a1c384) Review URL: https://codereview.chromium.org/2532273002 . Cr-Commit-Position: refs/branch-heads/2924@{#132} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/744ccc2c04a0811aeb9789e2fc9ad6fe5ae82a6b/ash/common/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/744ccc2c04a0811aeb9789e2fc9ad6fe5ae82a6b/ash/common/wm/overview/scoped_transform_overview_window.h [modify] https://crrev.com/744ccc2c04a0811aeb9789e2fc9ad6fe5ae82a6b/ash/wm/overview/window_selector_unittest.cc
,
Nov 28 2016
,
Dec 2 2016
Verified on ChromeOS 9000.15.0, 56.0.2924.12
,
Dec 15 2016
CL in #11 had wrong description, sorry. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sdantul...@chromium.org
, Nov 21 2016