Traceback when doing git cl upload --gerrit |
||||
Issue descriptionOS: Linux When uploading https://pdfium-review.googlesource.com/c/2031/, I got the following (it still uploaded): Using 50% similarity for rename/copy detection. Override with --similarity. Running presubmit upload checks ... Done processing /usr/local/google/home/npm/pdfium/pdfium/core/fpdfapi/font/cpdf_cidfont.h Done processing /usr/local/google/home/npm/pdfium/pdfium/core/fpdfapi/font/cpdf_font.cpp Done processing /usr/local/google/home/npm/pdfium/pdfium/core/fpdfapi/font/cpdf_font.h Presubmit checks passed. core/fpdfapi/font/cpdf_cidfont.h | 2 +- core/fpdfapi/font/cpdf_font.cpp | 4 ---- core/fpdfapi/font/cpdf_font.h | 5 ----- 3 files changed, 1 insertion(+), 10 deletions(-) remote: Processing changes: new: 1, done remote: remote: New Changes: remote: https://pdfium-review.googlesource.com/2031 Remove unused methods from CPDF_Font remote: To https://pdfium.googlesource.com/pdfium.git * [new branch] 99a1ae31b9b9c026a02e909535a9c06bf4278bec -> refs/for/refs/heads/master%notify=NONE Traceback (most recent call last): File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 5403, in <module> sys.exit(main(sys.argv[1:])) File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 5385, in main return dispatcher.execute(OptionParser(), argv) File "/usr/local/google/home/npm/depot_tools/subcommand.py", line 252, in execute return command(parser, args[1:]) File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 4210, in CMDupload return cl.CMDUpload(options, args, orig_args) File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 1614, in CMDUpload ret = self.CMDUploadChange(options, git_diff_args, change) File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 2851, in CMDUploadChange self._GetGerritHost(), self.GetIssue(), cc, is_reviewer=False) File "/usr/local/google/home/npm/depot_tools/gerrit_util.py", line 661, in AddReviewers _ = ReadHttpJsonResponse(conn, ignore_404=False) File "/usr/local/google/home/npm/depot_tools/gerrit_util.py", line 378, in ReadHttpJsonResponse conn, expect_status=expect_status, ignore_404=ignore_404) File "/usr/local/google/home/npm/depot_tools/gerrit_util.py", line 371, in ReadHttpResponse raise GerritError(response.status, reason) gerrit_util.GerritError: Not Found: Not found: 2031
,
Nov 23 2016
ping
,
Nov 28 2016
,
Nov 29 2016
The likely explanation is this: * pdfium-review allows Push on refs/for/* to Registered Users. So you can create a CL, whether or not you're recognized as a specially-ACL'd contributor. * but, you're not being recognized as a member of pdfium-committers, so it's not letting you do other things (like set reviewers, or upload additional patchsets). That means that you probably have a credential failure. What email address is set as "git config user.email" in this repo? Is that email address also used on the "pdfium-review.googlesource.com" line of your .gitcookies file?
,
Nov 29 2016
The email given by "git config user.email" is npm@chromium.org, and I checked that the line for pdfium-review.googlesource.com in gitcookies includes "git-npm.chromium.org=1". Also, git cl upload (uploading to https://codereview.chromium.org in pdfium) works fine for me. Are the permissions different?
,
Nov 29 2016
Yeah, the permissions for codereview.chromium.org and pdfium-review.googlesource.com are so different they're not even comparable. Hmm, you're definitely in pdfium-committers: https://pdfium-review.googlesource.com/#/admin/groups/uuid-483267b793affc296ed656cfbf210ca92d04d566 And pdfium-committers can definitely add patch sets to any review: https://pdfium-review.googlesource.com/#/admin/projects/All-Projects,access Is there another line in your .gitcookies for just "googlesource.com", with no subdomain? If so, it is probably overriding the one for pdfium-review.
,
Nov 29 2016
Oh, yes there is. It's below the other one (I don't know if order matters), and has my @google email.
,
Nov 29 2016
I'm also not sure if it uses order (last overrides others) or something else (most general wins) but I've seen this cause problems before. The best solution is to remove the generic googlesource.com line, and only have lines for each individual foo.googlesource.com host you actually use.
,
Nov 30 2016
Changing the order did not work. So I just got rid of the googlesource.com line. Thanks. |
||||
►
Sign in to add a comment |
||||
Comment 1 by npm@google.com
, Nov 21 2016Update: when I try to git cl upload an update to this patch, it won't let me, similar stack trace: Traceback (most recent call last): File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 5403, in <module> sys.exit(main(sys.argv[1:])) File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 5385, in main return dispatcher.execute(OptionParser(), argv) File "/usr/local/google/home/npm/depot_tools/subcommand.py", line 252, in execute return command(parser, args[1:]) File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 4210, in CMDupload return cl.CMDUpload(options, args, orig_args) File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 1575, in CMDUpload change = self.GetChange(base_branch, None) File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 1504, in GetChange description = self.GetDescription() File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 1426, in GetDescription self.description = self._codereview_impl.FetchDescription() File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 2462, in FetchDescription data = self._GetChangeDetail(['CURRENT_REVISION']) File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 2504, in _GetChangeDetail raise GerritIssueNotExists(issue, self.GetCodereviewServer()) __main__.GerritIssueNotExists: issue 2031 at https://pdfium-review.googlesource.com does not exist or you have no access to it