New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667489 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

smoothness.gpu_rasterization.[tough_scrolling_cases,tough_scrolling_cases.reference] failure on chromium.perf

Project Member Reported by charliea@chromium.org, Nov 21 2016

Issue description

Revision range first seen: ????? (failing before 10/23)
Link to failing step log: https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus9_Perf__2_%2F3435%2F%2B%2Frecipes%2Fsteps%2Fsmoothness.gpu_rasterization.tough_scrolling_cases.reference%2F0%2Fstdout

It doesn't seem that the same test case is always failing: I've seen both 15000px/second and 30000px/second fail. Some user story is failing at least 50% of the time, and has been since at least 10/23.

The failure log indicates that Chrome is crashing:

Traceback (most recent call last):
  _RunStoryAndProcessErrorIfNeeded at /b/rr/tmp07BZKa/w/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:110
    test.DidRunPage(state.platform)
  traced_function at /b/rr/tmp07BZKa/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:75
    return func(*args, **kwargs)
  DidRunPage at /b/rr/tmp07BZKa/w/src/tools/perf/measurements/smoothness.py:65
    self._tbm.DidRunStory(platform)
  DidRunStory at /b/rr/tmp07BZKa/w/src/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement.py:309
    platform.tracing_controller.StopTracing()
  StopTracing at /b/rr/tmp07BZKa/w/src/third_party/catapult/telemetry/telemetry/core/tracing_controller.py:47
    return self._tracing_controller_backend.StopTracing()
  StopTracing at /b/rr/tmp07BZKa/w/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:108
    self._IssueClockSyncMarker()
  _IssueClockSyncMarker at /b/rr/tmp07BZKa/w/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:203
    self._RecordIssuerClockSyncMarker)
  RecordClockSyncMarker at /b/rr/tmp07BZKa/w/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:175
    raise ChromeClockSyncError('Cannot issue clock sync. No devtools clients')
ChromeClockSyncError: Cannot issue clock sync. No devtools clients

I'm going to disable this benchmark on Android until this gets fixed. ericrk@, could you take responsibility for making sure that the right person investigates why this is happening?

If the test is disabled, please downgrade to Pri-2.

 
Cc: charliea@google.com
Cc: -charliea@google.com
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0d27a244acc55a0143ced89a1d4048c991be8e3

commit e0d27a244acc55a0143ced89a1d4048c991be8e3
Author: charliea <charliea@chromium.org>
Date: Tue Nov 22 15:45:06 2016

Disable smoothness.gpu_rasterization.tough_scrolling_cases everywhere

This benchmark fails more than 50% of the time on all Android devices
and has been since at least 10/23.

TBR=ericrk@chromium.org,nednguyen@google.com
BUG= 667489 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2520903003
Cr-Commit-Position: refs/heads/master@{#433869}

[modify] https://crrev.com/e0d27a244acc55a0143ced89a1d4048c991be8e3/tools/perf/benchmarks/smoothness.py

Cc: vmi...@chromium.org ericrk@chromium.org
Owner: senorblanco@chromium.org
Assigning this to senorblanco@. It looks like we're missing a benchmark owner for smoothness.gpu_rasterization.tough_scrolling_cases on go/chrome-benchmarks. Do you know who a good owner for this would be?
Cc: rbyers@chromium.org
Owner: vmi...@chromium.org
Sorry, I have no idea who owns this. Victor, do you know?

Comment 6 by vmi...@chromium.org, Nov 22 2016

Cc: reve...@chromium.org
Owner: ericrk@chromium.org
This was originally by reveman@, but I'm not sure he has time to maintain it.  ericrk@ could you take this?

Comment 7 by ericrk@chromium.org, Nov 22 2016

Sounds good - I'll look into it.
Any update on this?
Status: Archived (was: Assigned)
This issue was created > 6 months ago. The perf waterfall has changed significantly since then. If this bug is still relevant, please re-open.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e91f6968e7768275d7e37608c1228effd181d11

commit 4e91f6968e7768275d7e37608c1228effd181d11
Author: Ashley Enstad <ashleymarie@chromium.org>
Date: Wed Aug 09 16:42:53 2017

Reenabling some smoothness benchmarks

smoothness.tough_pinch_zoom_cases
smoothness.gpu_rasterization.tough_pinch_zoom_cases
smoothness.gpu_rasterization.tough_scrolling_cases

Bug:  631015 , 610021 , 667489 ,713222
Change-Id: I401beed0229fe2a6c990ecdbab9a01e5ac239c7d
Reviewed-on: https://chromium-review.googlesource.com/606113
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493021}
[modify] https://crrev.com/4e91f6968e7768275d7e37608c1228effd181d11/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/4e91f6968e7768275d7e37608c1228effd181d11/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/4e91f6968e7768275d7e37608c1228effd181d11/tools/perf/benchmarks/smoothness.py

Sign in to add a comment