New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667482 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Create and run manual test tracker tests to cover ffmpeg roll changes

Project Member Reported by crouleau@chromium.org, Nov 21 2016

Issue description

Yining,

Matt just rolled ffmpeg (which Chrome uses for demuxing and decoding). (Rolled means he updated the ffmpeg library to its latest version in the Chromium repository).

Here's what Matt says about it:

"""
tl;dr: Yes - the roll, since it includes about 8 months of upstream changes, is quite extensive. Current Canary vs Current Dev contains the roll delta. The roll, plus some follow-up work listed below, landed in range 433075-433433 in trunk.

Details:
The roll landed last Thursday in trunk. Friday night, the branch announcement made it clear that it missed this M56 cut @r433059 by < 20 commits. I've requested it be merged back to M56, and that request is pending manual review by the TPMs currently.

Apart from possible performance changes (improvements/regressions), feature changes of which I'm aware are:

- FLAC demux+decode support on all Chrom* brandings (not just ChromeOS)

- Opus audio decode capability as a shim to our third_party/libopus (Note, the roll disabled this new ability temporarily until Dale's https://codereview.chromium.org/2435603009/ landed over the weekend), rather than our custom OpusAudioDecoder.

- Anything related to cropped post-decode video; e.g. anything where ffmpeg previously emitted a coded width/height different than the actual decoded width/height: we no longer have access to the coded width/height during ffmpeg demux; actual decode though should not regress, since actual decode by ffmpeg still observes internally available coded size info, and decoders other than ffmpeg must be able to similarly function correctly. TBH, the latter is where I'm less familiar, and regardless I recall sandersd@ mentioning our pipeline (even before the roll) didn't handle all cropping cases correctly.
"""

Would you to able to write additional test cases to cover these changes and also consider what existing test cases could also be affected? Matt is a good contact to help with questions.

We should also look for regressions in AVA in power, freezing, smoothness, etc.

Please let me know if you can cover this work.
 
Cc: hubbe@chromium.org kqyang@chromium.org
One further item is that I'm told FFmpeg roll contains the ability to demux VP9-in-ISOBMFF. Folks like kqyang@ are working on adding Chromium-side support for that currently.

kqyang@ - is there anything currently testable around this new VP9-in-ISOBMFF, or does it depend on new tests being added (of which I think you were working on, per the vp9-in-isobmff thread)?

Comment 2 by kqyang@chromium.org, Nov 21 2016

Not currently. I'll update https://codereview.chromium.org/2495193004/ to add new tests (and still keep the feature disabled for now).
Caleb, how urgent this work is? I will spend the next 2~3 weeks on google update team, they have a release scheduled on Dec which include 2 big features. If this is not urgent, I can start to work on it in Jan. I will take last two weeks of Dec off.
Cc: yini...@chromium.org
Owner: crouleau@chromium.org
Yining, as discussed offline, we will find someone else for this work, and they will do it with your support.

See https://bugs.chromium.org/p/chromium/issues/detail?id=580623#c22 and #c23 for instructions to creating "vp9 in isobmff" video. We may need to put this in go/videotestmatrix so that we can add a test case for it.
Owner: ajnolley@chromium.org
Give to AJ to start. 
AJ, Feel free to ping me for anything. Here are the functionality tests for existing supported audio/video media types.
https://testtracker.googleplex.com/testplans/details/1635

If you have access to https://pantheon.corp.google.com/storage/browser/videostack/testdata/ it has some frame cropping videos in it. Not sure whether they could be helpful. (If you don't have access, I should be able to add you)
The bug for the roll is crbug/591845. 

Matt is figuring out which changes are currently in M56 dev right now to see if it is ready for you to test.
We're agreed that the relevant code is in m56 dev right now and is ready to be tested.
Status: Untriaged (was: Assigned)
I've finished testing, and found two issues:

 bug 672675 
 bug 672677 
Status: Fixed (was: Untriaged)
For future, here's the test plan: https://docs.google.com/document/d/18p0WGySLS5gJaguYTZ4x7tuWzZEJF3fCxh4va9x_tG8/edit

I'm marking this bug fixed.

Thanks for the help AJ!
Status: Verified (was: Fixed)

Sign in to add a comment