Unless the line number is stale, that would be WebRemoteFrameImpl::addMessageToConsole.

dcheng@ or lfg@, do you know if it's expected to hit addMessageToConsole in a remote frame?  Looks like it might happen in cases like WebViewImpl::ReportIntervention(), which has a line like:
mainFrame()->addMessageToConsole(consoleMessage);

(Not sure if there's others, but skyostil@ might know about that one.)

Is this something that makes sense to implement for remote frames?

Interventions that use this mechanism are generally renderer-local, so I don't think it makes sense to propagate them further than the local root. I'll put together a patch.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1eb6009ca491323f9fe18237cc2dddfc8eb399e

commit e1eb6009ca491323f9fe18237cc2dddfc8eb399e
Author: skyostil <skyostil@chromium.org>
Date: Thu Nov 24 14:43:46 2016

Only propagate intervention reports to local frames

Don't try to log console messages about interventions to remote frames
(which don't support this). Instead, report the intervention to the
local root.

BUG= 667481 

Review-Url: https://codereview.chromium.org/2522633003
Cr-Commit-Position: refs/heads/master@{#434317}

[modify] https://crrev.com/e1eb6009ca491323f9fe18237cc2dddfc8eb399e/third_party/WebKit/Source/web/WebViewImpl.cpp

The console log spam should be gone now, but it sounds like there's something else to fix here too?

I still sometimes see tons of these messages on 55.0.2883.82 (I have one log w/ 60 such messages per second). I guess it is too late, this will go out to stable.

Can we please ensure this is fixed for 56, too.

Deleted: ui.20161209-011423.txt 57.9 KB

ui.20161209-011423.txt 57.9 KB View Download

Your change meets the bar and is auto-approved for M56 (branch: 2924)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e23e3cca629df2eb01273ec4e69cd60a7dfb6ce

commit 4e23e3cca629df2eb01273ec4e69cd60a7dfb6ce
Author: Sami Kyostila <skyostil@chromium.org>
Date: Fri Dec 09 10:38:19 2016

Only propagate intervention reports to local frames

Don't try to log console messages about interventions to remote frames
(which don't support this). Instead, report the intervention to the
local root.

BUG= 667481 

Review-Url: https://codereview.chromium.org/2522633003
Cr-Commit-Position: refs/heads/master@{#434317}
(cherry picked from commit e1eb6009ca491323f9fe18237cc2dddfc8eb399e)

Review-Url: https://codereview.chromium.org/2561993002 .
Cr-Commit-Position: refs/branch-heads/2924@{#428}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/4e23e3cca629df2eb01273ec4e69cd60a7dfb6ce/third_party/WebKit/Source/web/WebViewImpl.cpp

According to the following, this fixed was cherry-picked to 56.0.2924.23:
https://chromium.googlesource.com/chromium/src/+log/56.0.2924.22..56.0.2924.23

However, I still see this log spam on current R56 image:
56.0.2924.28 (Official Build) beta (32-bit)
Platform	9000.29.0 (Official Build) beta-channel elm

[1:1:1227/115635.435142:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.
[1:1:1227/115635.737079:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.
[1:1:1227/115635.740228:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.
[1:1:1227/115636.435657:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.
[1:1:1227/115637.162240:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.
[1:1:1227/115637.768963:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.
[1:1:1227/115637.773223:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.
[1:1:1227/115638.479143:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.
[1:1:1227/115638.486911:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.
[1:1:1227/115639.071076:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.
[1:1:1227/115639.402617:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.
[1:1:1227/115639.706687:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.
[1:1:1227/115640.389146:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.
[1:1:1227/115640.474141:ERROR:WebRemoteFrameImpl.cpp(192)] NOTREACHED() hit.

Does CrOS preserve log strings on official builds? We could just try logging the actual string out to see what the culprit is.

(The real fix here is to just move this method from WebFrame to WebLocalFrame)

(assigning to myself as I'll just do the move now. Perhaps the move will even be mergeable, but even if it isn't, it'll help find any other interesting things that are not correctly checking this)

CL @ https://codereview.chromium.org/2601763002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a2307c7dd371719a6f21aa919efa9ce607e3f4c

commit 5a2307c7dd371719a6f21aa919efa9ce607e3f4c
Author: dcheng <dcheng@chromium.org>
Date: Fri Dec 30 13:35:10 2016

WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

Calling this method on a generic WebFrame doesn't make sense, since it
doesn't make sense to log things to a remote frame. Some code is
apparently doing this, and spamming the CrOS logs like crazy.

BUG=416660, 667481 
R=avi@chromium.org,haraken@chromium.org
TBR=rdevlin.cronin@chromium.org,thestig@chromium.org

Review-Url: https://codereview.chromium.org/2601763002
Cr-Commit-Position: refs/heads/master@{#441029}

[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/chrome/renderer/chrome_render_view_observer.cc
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/chrome/renderer/extensions/chrome_extensions_renderer_client.cc
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/chrome/renderer/extensions/chrome_extensions_renderer_client.h
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/chrome/renderer/extensions/resource_request_policy.cc
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/chrome/renderer/extensions/resource_request_policy.h
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/components/printing/renderer/print_web_view_helper.cc
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/components/printing/renderer/print_web_view_helper.h
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/content/renderer/renderer_webapplicationcachehost_impl.cc
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/extensions/shell/renderer/shell_content_renderer_client.cc
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/extensions/shell/renderer/shell_content_renderer_client.h
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/third_party/WebKit/Source/core/page/ChromeClient.cpp
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/third_party/WebKit/Source/web/WebRemoteFrameImpl.h
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/third_party/WebKit/public/web/WebFrame.h
[modify] https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c/third_party/WebKit/public/web/WebLocalFrame.h

Thank you for the fix, should the CL in #13 also be merged back?

 Issue 650566  has been merged into this issue.