New issue
Advanced search Search tips

Issue 667465 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Fix possible leak of IndexedDB internal data structures

Project Member Reported by reillyg@chromium.org, Nov 21 2016

Issue description

Version: 56.0.2922.1
OS: Any

During refactoring of r430110 the logic to actually delete the internal state of IndexedDBCallbacksImpl and IndexedDBDatabaseCallbacksImpl objects that live on worker threads was accidentally removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff03e42e8773445a9ee1649dbcbb5b4aae7c2567

commit ff03e42e8773445a9ee1649dbcbb5b4aae7c2567
Author: reillyg <reillyg@chromium.org>
Date: Tue Nov 22 00:03:51 2016

[IndexedDB] Delete callbacks state on worker thread exit.

During refactoring of r430110 the logic to actually delete the internal
state of IndexedDBCallbacksImpl and IndexedDBDatabaseCallbacksImpl
objects that lives on worker threads was accidentally removed.

BUG= 667465 

Review-Url: https://codereview.chromium.org/2525443002
Cr-Commit-Position: refs/heads/master@{#433707}

[modify] https://crrev.com/ff03e42e8773445a9ee1649dbcbb5b4aae7c2567/content/child/indexed_db/indexed_db_dispatcher.cc
[modify] https://crrev.com/ff03e42e8773445a9ee1649dbcbb5b4aae7c2567/content/child/indexed_db/indexed_db_dispatcher.h

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bc73223a90a764ce06cedd247bb09989aad3d08

commit 9bc73223a90a764ce06cedd247bb09989aad3d08
Author: piman <piman@chromium.org>
Date: Tue Nov 22 01:11:45 2016

Revert of [IndexedDB] Delete callbacks state on worker thread exit. (patchset #1 id:1 of https://codereview.chromium.org/2525443002/ )

Reason for revert:
Likely cause of storage/indexeddb/pending-version-change-stuck-works-with-terminate.html crashes:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/20218
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/26874

Original issue's description:
> [IndexedDB] Delete callbacks state on worker thread exit.
>
> During refactoring of r430110 the logic to actually delete the internal
> state of IndexedDBCallbacksImpl and IndexedDBDatabaseCallbacksImpl
> objects that lives on worker threads was accidentally removed.
>
> BUG= 667465 
>
> Committed: https://crrev.com/ff03e42e8773445a9ee1649dbcbb5b4aae7c2567
> Cr-Commit-Position: refs/heads/master@{#433707}

TBR=jsbell@chromium.org,reillyg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 667465 

Review-Url: https://codereview.chromium.org/2521773003
Cr-Commit-Position: refs/heads/master@{#433725}

[modify] https://crrev.com/9bc73223a90a764ce06cedd247bb09989aad3d08/content/child/indexed_db/indexed_db_dispatcher.cc
[modify] https://crrev.com/9bc73223a90a764ce06cedd247bb09989aad3d08/content/child/indexed_db/indexed_db_dispatcher.h

Status: Started (was: Fixed)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d1044b605d7dfa073437e09fd966f306137a0c9

commit 6d1044b605d7dfa073437e09fd966f306137a0c9
Author: reillyg <reillyg@chromium.org>
Date: Tue Nov 22 23:57:12 2016

Reland: [IndexedDB] Delete callbacks state on worker thread exit.

During refactoring of r430110 the logic to actually delete the internal
state of IndexedDBCallbacksImpl and IndexedDBDatabaseCallbacksImpl
objects that lives on worker threads was accidentally removed.

This reland will fix the DCHECK encountered when actually exercising
this deletion path.

BUG= 667465 

Review-Url: https://codereview.chromium.org/2524823002
Cr-Commit-Position: refs/heads/master@{#434030}

[modify] https://crrev.com/6d1044b605d7dfa073437e09fd966f306137a0c9/content/child/indexed_db/indexed_db_dispatcher.cc
[modify] https://crrev.com/6d1044b605d7dfa073437e09fd966f306137a0c9/content/child/indexed_db/indexed_db_dispatcher.h

Status: Fixed (was: Started)
Labels: Merge-Request-56

Comment 8 by dimu@chromium.org, Nov 23 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 23 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5646073b3867c4b59a83a502bad6ba5681816d8

commit c5646073b3867c4b59a83a502bad6ba5681816d8
Author: Reilly Grant <reillyg@chromium.org>
Date: Wed Nov 23 18:54:18 2016

Reland: [IndexedDB] Delete callbacks state on worker thread exit.

During refactoring of r430110 the logic to actually delete the internal
state of IndexedDBCallbacksImpl and IndexedDBDatabaseCallbacksImpl
objects that lives on worker threads was accidentally removed.

This reland will fix the DCHECK encountered when actually exercising
this deletion path.

BUG= 667465 

Review-Url: https://codereview.chromium.org/2524823002
Cr-Commit-Position: refs/heads/master@{#434030}
(cherry picked from commit 6d1044b605d7dfa073437e09fd966f306137a0c9)

Review URL: https://codereview.chromium.org/2526913002 .

Cr-Commit-Position: refs/branch-heads/2924@{#81}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/c5646073b3867c4b59a83a502bad6ba5681816d8/content/child/indexed_db/indexed_db_dispatcher.cc
[modify] https://crrev.com/c5646073b3867c4b59a83a502bad6ba5681816d8/content/child/indexed_db/indexed_db_dispatcher.h

Sign in to add a comment