New issue
Advanced search Search tips

Issue 667455 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

No Scrollbar shows in Devtool/timeline with MD scrollbar

Project Member Reported by chaopeng@chromium.org, Nov 21 2016

Issue description

Version: 56.0.2921.0
OS: Linux

What steps will reproduce the problem?
(1) Open Devtool-timeline
(2) Record(ctrl-r) and stop
(3) move mouse to second part and scroll with wheel

What is the expected result?

There is a v-scrollbar shows with Not-MD scrollbar

What happens instead?

No v-scrollbar shows

Mouse wheel scroll map to zoom-in/out here and we can not see the content below if we don't have a v-scrollbar shows.
 
Description: Show this description
Labels: -Pri-3 M-56 Pri-1

Comment 4 by bokan@chromium.org, Nov 22 2016

Labels: -M-56 M-57
Labels: Hotlist-Input-Dev
Components: Blink>Scroll

Comment 7 by bokan@chromium.org, Feb 9 2017

Status: Assigned (was: Untriaged)

Comment 8 by bokan@chromium.org, Feb 9 2017

Components: -Blink>Scroll UI>Shell
Labels: -Pri-1 -M-57 Pri-3
Project Member

Comment 9 by bugdroid1@chromium.org, May 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3bf5300114f14aedbe82f3ece0d142408ac7db7

commit e3bf5300114f14aedbe82f3ece0d142408ac7db7
Author: chaopeng <chaopeng@chromium.org>
Date: Sun May 14 02:47:47 2017

force non-overlay scrollbars in all platform in flamechart

Since overlay Scrollbar will make the v-scrollbar disappear in
DevTools/Timeline. In this patch we modify the DevTools/Timeline
v-scrollbar to custom scrollbar the same as what we did in MacOS.

BUG= 667455 

Review-Url: https://codereview.chromium.org/2524783002
Cr-Commit-Position: refs/heads/master@{#471615}

[modify] https://crrev.com/e3bf5300114f14aedbe82f3ece0d142408ac7db7/third_party/WebKit/Source/devtools/front_end/perf_ui/flameChart.css

Comment 10 by alph@chromium.org, May 15 2017

The patch made scrollbars inconsistent on Linux.
Screenshot from 2017-05-15 10:48:11.png
29.5 KB View Download
Maybe we should only apply border-radius: 50px for Mac?
Project Member

Comment 12 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/463ea7fadc00a36b3a83860c64c0aa4fe0338d0a

commit 463ea7fadc00a36b3a83860c64c0aa4fe0338d0a
Author: alph <alph@chromium.org>
Date: Mon May 15 19:29:57 2017

Revert of force non-overlay scrollbars in all platform in flamechart (patchset #2 id:20001 of https://codereview.chromium.org/2524783002/ )

Reason for revert:
The patch made scrollbars inconsistent on Linux. See the comment #10 in  crbug.com/667455 

Original issue's description:
> force non-overlay scrollbars in all platform in flamechart
>
> Since overlay Scrollbar will make the v-scrollbar disappear in
> DevTools/Timeline. In this patch we modify the DevTools/Timeline
> v-scrollbar to custom scrollbar the same as what we did in MacOS.
>
> BUG= 667455 
>
> Review-Url: https://codereview.chromium.org/2524783002
> Cr-Commit-Position: refs/heads/master@{#471615}
> Committed: https://chromium.googlesource.com/chromium/src/+/e3bf5300114f14aedbe82f3ece0d142408ac7db7

TBR=bokan@chromium.org,caseq@chromium.org,dgozman@chromium.org,chaopeng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 667455 

Review-Url: https://codereview.chromium.org/2880373003
Cr-Commit-Position: refs/heads/master@{#471862}

[modify] https://crrev.com/463ea7fadc00a36b3a83860c64c0aa4fe0338d0a/third_party/WebKit/Source/devtools/front_end/perf_ui/flameChart.css

Project Member

Comment 13 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0feb73390c78b48c59b47bbf3870a6d897dddcd0

commit 0feb73390c78b48c59b47bbf3870a6d897dddcd0
Author: chaopeng <chaopeng@chromium.org>
Date: Wed May 24 03:41:16 2017

Force non overlay scrollbar in Devtools/Performance for Aura Overlay Scrollbar

Since Aura overlay Scrollbar will make the v-scrollbar disappear in
DevTools/Performance. In this patch we modify the DevTools/Performance
v-scrollbar to custom scrollbar when detected Aura Overlay Scrollbar
enabled. For detecting Aura Overlay Scrollbar, we also add
overlayScrollbarEnabled in UI.installComponentRootStyles and add
overlay-scrollbar-enabled class to document body.

BUG= 667455 

Review-Url: https://codereview.chromium.org/2891383002
Cr-Commit-Position: refs/heads/master@{#474150}

[modify] https://crrev.com/0feb73390c78b48c59b47bbf3870a6d897dddcd0/third_party/WebKit/Source/devtools/front_end/perf_ui/flameChart.css
[modify] https://crrev.com/0feb73390c78b48c59b47bbf3870a6d897dddcd0/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Status: Fixed (was: Assigned)

Sign in to add a comment