New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 667448 link

Starred by 1 user
Status: Fixed
Owner:
achuith@chromium.org
Closed: Nov 2016
Cc:
glevin@chromium.org
█ yukuairoy@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Do not display goodies for --no-first-run

Project Member Reported by achuith@chromium.org, Nov 21 2016 
We see goodies in tests that specifiy --no-first-run that clear the local state before each run. We should suppress goodies in this case.

https://cs.chromium.org/chromium/src/chrome/browser/chromeos/first_run/goodies_displayer.cc?l=122

Comment 1 by achuith@chromium.org, Nov 21 2016

Cc: -achuith@chromium.org glevin@chromium.org
Owner: achuith@chromium.org
Status: Started (was: Assigned)
https://codereview.chromium.org/2519173003/
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97ec92a6e1499fda8e3bf08d515381f5595fee23

commit 97ec92a6e1499fda8e3bf08d515381f5595fee23
Author: achuith <achuith@chromium.org>
Date: Tue Nov 22 22:39:54 2016

Do not display goodies with --no-first-run.

Make the browsertest parameterized with --no-first-run.

BUG= chromium:667448 
TEST=browsertest

Review-Url: https://codereview.chromium.org/2519173003
Cr-Commit-Position: refs/heads/master@{#434008}

[modify] https://crrev.com/97ec92a6e1499fda8e3bf08d515381f5595fee23/chrome/browser/chromeos/first_run/goodies_displayer.cc
[modify] https://crrev.com/97ec92a6e1499fda8e3bf08d515381f5595fee23/chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc

Comment 3 by achuith@chromium.org, Nov 22 2016

Status: Fixed (was: Started)
►

Sign in to add a comment