New issue
Advanced search Search tips

Issue 667439 link

Starred by 3 users
Status: Verified
Owner: ----
Closed: Jan 2017
Cc:
lpalmaro@chromium.org
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility

Blocking:
issue 665103



Sign in to add a comment

Disable ChromeVox touchscreen enable in M56

Project Member Reported by kathrelk...@chromium.org, Nov 21 2016 
I have turned this feature on accidentally several times while using a stylus.  One time, after switching between touchview and laptop modes,  the sound played while no fingers were on the screen.

We have no great repro of the problem yet, other than having your hand rest in a way that looks like two fingers (while using the stylus).

Spoke with Dominic and we agreed to turn it off in M56 and investigate further in M57.

Comment 1 by kathrelk...@chromium.org, Dec 1 2016

Labels: ReleaseBlock-Stable

Comment 2 by dmazz...@chromium.org, Dec 1 2016 

Reverting with this change, then will need to merge the revert:
https://codereview.chromium.org/2535723008/
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2173f056c9a7faf6e4270cb46c264ace433e4e64

commit 2173f056c9a7faf6e4270cb46c264ace433e4e64
Author: dmazzoni <dmazzoni@chromium.org>
Date: Thu Dec 01 01:35:51 2016

Revert "Toggle spoken feedback if two fingers are held down."

Originally landed in r432129 and r434618. Reverting so we can merge
the revert to M56, then will re-land and keep tweaking on trunk.

BUG= 662501 , 667439 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=oshima,sadrul,michaelpg

Review-Url: https://codereview.chromium.org/2535723008
Cr-Commit-Position: refs/heads/master@{#435519}

[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ash/ash_touch_exploration_manager_chromeos.h
[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ash/common/accessibility_delegate.h
[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ash/common/default_accessibility_delegate.cc
[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ash/common/default_accessibility_delegate.h
[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/chrome/browser/browser_resources.grd
[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/chrome/browser/chromeos/accessibility/accessibility_manager.h
[delete] https://crrev.com/1d83f16c4e8a49c614479bbd5e74f16aad7c8232/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_high.wav
[delete] https://crrev.com/1d83f16c4e8a49c614479bbd5e74f16aad7c8232/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_low.wav
[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/chromeos/audio/chromeos_sounds.h
[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ui/chromeos/BUILD.gn
[delete] https://crrev.com/1d83f16c4e8a49c614479bbd5e74f16aad7c8232/ui/chromeos/touch_accessibility_enabler.cc
[delete] https://crrev.com/1d83f16c4e8a49c614479bbd5e74f16aad7c8232/ui/chromeos/touch_accessibility_enabler.h
[delete] https://crrev.com/1d83f16c4e8a49c614479bbd5e74f16aad7c8232/ui/chromeos/touch_accessibility_enabler_unittest.cc
[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ui/chromeos/touch_exploration_controller.cc
[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ui/chromeos/touch_exploration_controller.h
[modify] https://crrev.com/2173f056c9a7faf6e4270cb46c264ace433e4e64/ui/chromeos/touch_exploration_controller_unittest.cc

Comment 4 by dmazz...@chromium.org, Dec 1 2016

Labels: Merge-Request-56
Status: Started (was: Untriaged)

Comment 5 by gkihumba@chromium.org, Dec 1 2016

Labels: Merge-Approved-56
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 1 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2472b5999c08830451e70d903b49ce3e609cc0de

commit 2472b5999c08830451e70d903b49ce3e609cc0de
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Thu Dec 01 21:02:40 2016

Merge to M56: Revert "Toggle spoken feedback if two fingers are held down."

Originally landed in r432129 and r434618. Reverting so we can merge
the revert to M56, then will re-land and keep tweaking on trunk.

BUG= 662501 , 667439 
TBR=oshima,sadrul,michaelpg
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review URL: https://codereview.chromium.org/2540333004 .

Cr-Commit-Position: refs/branch-heads/2924@{#263}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ash/ash_touch_exploration_manager_chromeos.h
[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ash/common/accessibility_delegate.h
[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ash/common/default_accessibility_delegate.cc
[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ash/common/default_accessibility_delegate.h
[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/chrome/browser/browser_resources.grd
[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/chrome/browser/chromeos/accessibility/accessibility_manager.h
[delete] https://crrev.com/9a3c05c817412f456802d7e150d10a2c36eb9eff/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_high.wav
[delete] https://crrev.com/9a3c05c817412f456802d7e150d10a2c36eb9eff/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_low.wav
[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/chromeos/audio/chromeos_sounds.h
[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ui/chromeos/BUILD.gn
[delete] https://crrev.com/9a3c05c817412f456802d7e150d10a2c36eb9eff/ui/chromeos/touch_accessibility_enabler.cc
[delete] https://crrev.com/9a3c05c817412f456802d7e150d10a2c36eb9eff/ui/chromeos/touch_accessibility_enabler.h
[delete] https://crrev.com/9a3c05c817412f456802d7e150d10a2c36eb9eff/ui/chromeos/touch_accessibility_enabler_unittest.cc
[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ui/chromeos/touch_exploration_controller.cc
[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ui/chromeos/touch_exploration_controller.h
[modify] https://crrev.com/2472b5999c08830451e70d903b49ce3e609cc0de/ui/chromeos/touch_exploration_controller_unittest.cc

Comment 7 by dimu@chromium.org, Dec 1 2016

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
[Automated comment] Reverts referenced in bugdroid comments, after merge request, needs manual review.

Comment 8 by kathrelk...@chromium.org, Dec 1 2016

Labels: -Hotlist-Merge-Review -Merge-Review-56
was already merged to M56

Comment 9 by kathrelk...@chromium.org, Dec 1 2016

Blocking: 665103

Comment 10 by marc.her...@gmail.com, Dec 13 2016 

This hasn't made it to the dev channel yet. Quoting myself from (duplicate, my bad)  Issue 672362 

> all Android apps that depend on multitouch are unusable on the dev channel right now.

Comment 11 by gkihumba@chromium.org, Dec 13 2016

Labels: -M-56 -ReleaseBlock-Stable M-57
Looks like it's not a feature in M56, removing ReleaseBlock-Stable for M56
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16d2dec10b4a9ae2259658a474cd6867f82d08e3

commit 16d2dec10b4a9ae2259658a474cd6867f82d08e3
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Dec 19 23:27:57 2016

Re-land: Toggle spoken feedback if two fingers are held down.

Originally landed in r432129 and r434618, reverted in r435519 because
it was triggering too often.

Re-landing this time but modifying it to only apply to Chromebox For Meetings
devices.

Original CL: https://codereview.chromium.org/2476843003

BUG= 662501 , 667439 
TBR=oshima,sadrul,michaelpg
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2584063002
Cr-Commit-Position: refs/heads/master@{#439611}

[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ash/ash_touch_exploration_manager_chromeos.h
[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ash/common/accessibility_delegate.h
[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ash/common/default_accessibility_delegate.cc
[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ash/common/default_accessibility_delegate.h
[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chrome/browser/browser_resources.grd
[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chrome/browser/chromeos/accessibility/accessibility_manager.h
[add] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_high.wav
[add] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_low.wav
[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/chromeos/audio/chromeos_sounds.h
[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/BUILD.gn
[add] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/touch_accessibility_enabler.cc
[add] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/touch_accessibility_enabler.h
[add] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/touch_accessibility_enabler_unittest.cc
[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/touch_exploration_controller.cc
[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/touch_exploration_controller.h
[modify] https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3/ui/chromeos/touch_exploration_controller_unittest.cc

Comment 13 by dmazz...@chromium.org, Jan 31 2017

Status: Fixed (was: Started)

Comment 14 by kathrelk...@chromium.org, Apr 4 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment