New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 28 users
Status: WontFix
Owner:
Closed: Nov 20
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment
Add true color correct rendering mode (umbrella bug)
Project Member Reported by ccameron@chromium.org, Nov 21 2016 Back to list
This is to track the development of true color correct rendering.

This feature is under development behind the flag --enable-color-correct-rendering.

This rendering mode (in contrast with legacy color correct rendering in  issue 667431 , which is --enable-legacy-color-correct-rendering) has correctly linear interpolation of colors.

See details in
https://docs.google.com/document/d/1BMyXXTmiAragmt5ukVBIIOLDthd7JcJBgGMt-PwuTHY/edit#

The main work items for this will be
- tagging all images with a renderable color space (sRGB or linear)
- specifying 
- doing color correct rendering in the compositor (including linear blending)

In the long term, this mode will need to exist side-by-side with legacy color mode. For the moment, this can be an either-or mode.
 
Blockedon: 662715
Blocking: -662715
Blockedon: 655247
Comment 3 by y...@yoav.ws, Nov 21 2016
Cc: y...@yoav.ws
Project Member Comment 4 by bugdroid1@chromium.org, Nov 29 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41530d89b006f3f25c03a074a0eb217ab6caee0a

commit 41530d89b006f3f25c03a074a0eb217ab6caee0a
Author: ccameron <ccameron@chromium.org>
Date: Tue Nov 29 06:12:33 2016

Add --enable-true-color-rendering flag

This feature has been split off from --enable-color-correct-rendering

enable-color-correct-rendering is a tweaking of the existing color
awareness to be more consistent and robust, and will only be noticeable
on non-sRGB monitor.

enable-true-color-rendering does all blending and interpolation
operations in a physically correct linear space, and has perceptually
noticeable differences on all monitors.

TBR=achuith,avi,pdr
BUG= 667433 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2530503003
Cr-Commit-Position: refs/heads/master@{#434909}

[modify] https://crrev.com/41530d89b006f3f25c03a074a0eb217ab6caee0a/cc/base/switches.cc
[modify] https://crrev.com/41530d89b006f3f25c03a074a0eb217ab6caee0a/cc/base/switches.h
[modify] https://crrev.com/41530d89b006f3f25c03a074a0eb217ab6caee0a/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/41530d89b006f3f25c03a074a0eb217ab6caee0a/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/41530d89b006f3f25c03a074a0eb217ab6caee0a/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/41530d89b006f3f25c03a074a0eb217ab6caee0a/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/41530d89b006f3f25c03a074a0eb217ab6caee0a/content/public/common/web_preferences.h
[modify] https://crrev.com/41530d89b006f3f25c03a074a0eb217ab6caee0a/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/41530d89b006f3f25c03a074a0eb217ab6caee0a/content/renderer/render_view_impl.cc
[modify] https://crrev.com/41530d89b006f3f25c03a074a0eb217ab6caee0a/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/41530d89b006f3f25c03a074a0eb217ab6caee0a/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/41530d89b006f3f25c03a074a0eb217ab6caee0a/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/41530d89b006f3f25c03a074a0eb217ab6caee0a/ui/compositor/compositor.cc

Blockedon: 669470
Blockedon: 655171
Blockedon: 671346
I'm unsure what happened here. I Have seen better colors in the Betas of 54 i think and now everything is back to the old broken colors in Beta 55 and the latest Canary again.

What happened?
I just had the time to play around with everything and it looks like --enable-color-correct-rendering does have a big effect on my setup (macOS 10.12.2, nVidia GTX960 with WebDrivers, Dell UP2715k display (wider color gammut). Unfortunately this effect totally break up colors and makes them even more unrealistic then using chrome without any flag.

Using --enable-true-color-rendering doesn't have any visible effect compared to non-flag.
These flags are not ready for public testing yet.
when i add the --enable-color-correct-rendering to chrome 57 on windows 10 x64, the chrome window only flashes shortly and imedialy closes afterwards..
Project Member Comment 12 by bugdroid1@chromium.org, Mar 15 2017
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b59418b55e5b899b7e11ad34ebd2df269baf5708

commit b59418b55e5b899b7e11ad34ebd2df269baf5708
Author: ccameron <ccameron@chromium.org>
Date: Wed Mar 15 02:52:54 2017

color: Remove flags for true color rendering

This is having too many complicated interactions with color correct
rendering and rasterization, and can be re-added (probably in a slightly
different form) once color correct render is on by default.

R=esprehn
TBR=achuith (for chrome/browser/chromeos/login)
BUG= 667433 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2755583003
Cr-Commit-Position: refs/heads/master@{#456969}

[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/cc/base/switches.cc
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/cc/base/switches.h
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/content/public/common/content_switches.cc
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/content/public/common/web_preferences.h
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/content/renderer/render_view_impl.cc
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/b59418b55e5b899b7e11ad34ebd2df269baf5708/ui/compositor/compositor.cc

Aww having just one flag is pretty nice, as the different between "colorCorrectRendering" and "trueColorCorrectRendering" wasn´t that clear anyway.. I saw that colorCorrectRendering now enables all the features which are where enabled by trueColorCorrectRendering before!
Comment 14 by rndme...@gmail.com, Apr 24 2017
Same as  timo.wi...@gmail.com above.

When launching Chrome with the option is crashes as soon as it tries to load a page.

In Windows' Color Management settings, if I change my custom ICC profile to the 
sRGB profile, or some other default one, then Chrome doesn't crash (but no color correction happens)

Chrome Version: 58.0.3029.81
Operating System: Windows NT 10.0.15063

****DO NOT CHANGE BELOW THIS LINE****
Crash ID: crash/d409d42590000000

Cc: msrchandra@chromium.org
 Issue 353818  has been merged into this issue.
Status: WontFix
We'll be pursuing linear color spaces via canvas extensions.
Sign in to add a comment