New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
link

Issue 667431: Add color correct rendering mode (umbrella bug)

Reported by ccameron@chromium.org, Nov 21 2016 Project Member

Issue description

Legacy color correct rendering is not actually color correct, in that all linear interpolation is done by output pixel values, not by color values (as in a linear space).

The flag --enable-color-correct-rendering will continue to exist and imply color correct interpolation (and its implications for blending, etc). This is the simpler of the two color modes.

See details in
https://docs.google.com/document/d/1BMyXXTmiAragmt5ukVBIIOLDthd7JcJBgGMt-PwuTHY/edit#

The new flag --enable-legacy-color-correct-rendering will be used to develop the legacy mode. This mode's main features are
- coherently handling CSS and image colors
- doing all canvas rendering in sRGB space
- doing input color conversion in the compositor

The main features of this will be broken into sub-bugs.
 

Comment 1 by ccameron@chromium.org, Nov 21 2016

Summary: Add legacy color correct rendering mode (umbrella bug) (was: Add legacy color correct rendering mode)

Comment 2 by ccameron@chromium.org, Nov 21 2016

Blockedon: 648707

Comment 3 by ccameron@chromium.org, Nov 21 2016

Cc: junov@chromium.org pinkerton@chromium.org chrishtr@chromium.org noel@chromium.org brettw@chromium.org bsalo...@google.com tpayne@chromium.org caryclark@chromium.org ccameron@chromium.org senorblanco@chromium.org hcm@chromium.org rponnada@chromium.org reed@google.com shrike@chromium.org
 Issue 44872  has been merged into this issue.

Comment 4 by ccameron@chromium.org, Nov 23 2016

Blockedon: 667966

Comment 5 by ccameron@chromium.org, Dec 1 2016

Cc: kavvaru@chromium.org durga.behera@chromium.org
 Issue 581109  has been merged into this issue.

Comment 6 by ccameron@chromium.org, Dec 8 2016

Blockedon: 672295

Comment 7 by ccameron@chromium.org, Dec 8 2016

Blockedon: 672299

Comment 8 by ccameron@chromium.org, Dec 8 2016

Blockedon: 672306

Comment 9 by ccameron@chromium.org, Dec 8 2016

Blockedon: 672309

Comment 10 by ccameron@chromium.org, Dec 8 2016

Blockedon: 672315

Comment 11 by ccameron@chromium.org, Dec 8 2016

Blockedon: 672316

Comment 12 by ccameron@chromium.org, Dec 8 2016

Blockedon: 665919

Comment 14 by ccameron@chromium.org, Dec 21 2016

Cc: dcasta...@chromium.org w...@chromium.org dalecur...@chromium.org sande...@chromium.org
 Issue 551861  has been merged into this issue.

Comment 15 by ccameron@chromium.org, Jan 6 2017

Blockedon: 679080

Comment 16 by ccameron@chromium.org, Feb 27 2017

Blockedon: -672295

Comment 17 by ccameron@chromium.org, Feb 27 2017

Blockedon: -672306

Comment 18 by ccameron@chromium.org, Feb 27 2017

Blockedon: -672309

Comment 19 by ccameron@chromium.org, Feb 27 2017

Blockedon: -672315

Comment 20 by ccameron@chromium.org, Feb 27 2017

Blockedon: -672316

Comment 21 by ccameron@chromium.org, Feb 27 2017

Blockedon: -679080

Comment 22 by ccameron@chromium.org, Mar 2 2017

Blockedon: 697675

Comment 23 by ccameron@chromium.org, Mar 27 2017

 Issue 692671  has been merged into this issue.

Comment 24 by ccameron@chromium.org, Apr 6 2017

 Issue 709068  has been merged into this issue.

Comment 25 by ccameron@chromium.org, Apr 10 2017

Blockedon: 706662

Comment 26 by bugdroid1@chromium.org, Apr 14 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c570ec9ef30d7e956a199fc309f6ff6642637f58

commit c570ec9ef30d7e956a199fc309f6ff6642637f58
Author: ccameron <ccameron@chromium.org>
Date: Fri Apr 14 05:36:25 2017

Add color correct rendering to about:flags

This feature will be enabled slowly across all platforms, and eventually
will be on by default for everyone. Leave this as a tri-state option
(default, enable, disable), although at the moment is never on by
default.

BUG= 667431 

Review-Url: https://codereview.chromium.org/2807423002
Cr-Commit-Position: refs/heads/master@{#464683}

[modify] https://crrev.com/c570ec9ef30d7e956a199fc309f6ff6642637f58/chrome/browser/about_flags.cc
[modify] https://crrev.com/c570ec9ef30d7e956a199fc309f6ff6642637f58/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c570ec9ef30d7e956a199fc309f6ff6642637f58/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c570ec9ef30d7e956a199fc309f6ff6642637f58/tools/metrics/histograms/histograms.xml

Comment 27 by ccameron@chromium.org, Apr 18 2017

Blockedon: 676054

Comment 28 by ccameron@chromium.org, Apr 18 2017

Blockedon: 709695 701942

Comment 29 Deleted

Comment 30 by ccameron@chromium.org, May 3 2017

Blockedon: 368663

Comment 31 by ccameron@chromium.org, May 3 2017

Cc: scroggo@chromium.org
 Issue 585931  has been merged into this issue.

Comment 32 by ccameron@chromium.org, May 4 2017

Cc: rbasuvula@chromium.org
 Issue 710196  has been merged into this issue.

Comment 33 by ccameron@chromium.org, May 9 2017

Blockedon: 719735

Comment 34 by ccameron@chromium.org, May 9 2017

Blockedon: 719664

Comment 35 by ccameron@chromium.org, May 9 2017

Blockedon: 714323

Comment 36 by ccameron@chromium.org, May 9 2017

Blockedon: 719893

Comment 37 by ccameron@chromium.org, May 9 2017

Blockedon: 720083

Comment 38 by ccameron@chromium.org, Nov 20 2017

Status: Fixed (was: Assigned)
Summary: Add color correct rendering mode (umbrella bug) (was: Add legacy color correct rendering mode (umbrella bug))

Sign in to add a comment