New issue
Advanced search Search tips

Issue 667419 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

mash: simplechrome deploy_chrome --mash broken on manifest.json files

Project Member Reported by jamescook@chromium.org, Nov 21 2016

Issue description

Inside cros chrome-sdk --board=edgar:

deploy_chrome --mash ...

<class 'chromite.lib.chrome_util.MissingPathError'>: /w/chrome/src/out/edgar/*_manifest.json does not exist and is required.
You can bypass this error with --sloppy.
Aborting copy...
Traceback (most recent call last):
  File "/w/chrome/src/third_party/chromite/lib/parallel.py", line 441, in _Run
    self._task(*self._task_args, **self._task_kwargs)
  File "/w/chrome/src/third_party/chromite/lib/parallel.py", line 653, in ReturnWrapper
    queue.put(fn())
  File "/w/chrome/src/third_party/chromite/scripts/deploy_chrome.py", line 298, in _PrepareStagingDir
    self.copy_paths, self.chrome_dir)
  File "/w/chrome/src/third_party/chromite/scripts/deploy_chrome.py", line 597, in _PrepareStagingDir
    strip_flags=strip_flags, copy_paths=copy_paths)
  File "/w/chrome/src/third_party/chromite/lib/chrome_util.py", line 445, in StageChromeFromBuildDir
    copied_paths += copier.Copy(build_dir, staging_dir, p, sloppy=sloppy)
  File "/w/chrome/src/third_party/chromite/lib/chrome_util.py", line 190, in Copy
    raise MissingPathError(msg)
MissingPathError: /w/chrome/src/out/edgar/*_manifest.json does not exist and is required.

chrome r433327 which is 73b3a441a128d14c81bed7afc981d35f0f401f1d (from Friday).

That contains chromite 2838d2b712a95224d7d9a84100891c45deb238f5 (from November 4) which supposedly includes a CL to fix this and a revert. See https://bugs.chromium.org/p/chromium/issues/detail?id=656726

chrome_util.py is still looking for *_manifest.json: https://chromium.googlesource.com/chromiumos/chromite/+/master/lib/chrome_util.py#381

Deleting that line seems to work. However, there may be other cleanup to do here. (For example, it would be nice to delete all the Envoy stuff.)

Note that Chrome won't start correctly even with this fixed: "black screen is  crbug.com/665544  which is another issue. DRM is finding 0 displays."

 

Comment 1 by sadrul@chromium.org, Nov 30 2016

Status: Fixed (was: Assigned)
https://chromium-review.googlesource.com/#/c/413110/ should fix this (rolled into the chrome tree in crrev.com/434742)

Comment 2 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 3 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 4 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment