Send Quirks Server a human-readable display name to identify common external displays |
|||||||
Issue descriptionAt present, the Quirks Client (Chrome OS) only sends the server the Manufacturer ID and Product Code, which is sufficient to retrieve an icc file. However, we would also like to know which external displays are the most common. To this end we would like to append a "&name=" item to the server request URL, with a human-readable display name taken from the EDID. The client will need to find and append this name to the URL, and the server will need to read and store it along with the display id. tbuckley@, abodenha@ - I believe that we decided to move forward with this. Let me know if you have any concerns before I begin. sjoe@ - There will need to be matching work on the server to accommodate this new info in the request.
,
Feb 27 2017
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2aa9dd13b0ba68a0f493c86f80b1bb0f3ceffc41 commit 2aa9dd13b0ba68a0f493c86f80b1bb0f3ceffc41 Author: glevin <glevin@chromium.org> Date: Thu Mar 16 21:07:59 2017 Include display names in Quirks URL BUG= 667416 TEST=Enable VLOGing for Quirks, plug in an external display, check log, verify that Quirks URL includes display name (roughly the same name as seen in display settings for 2nd monitor). Review-Url: https://codereview.chromium.org/2746443002 Cr-Commit-Position: refs/heads/master@{#457551} [modify] https://crrev.com/2aa9dd13b0ba68a0f493c86f80b1bb0f3ceffc41/ash/display/display_color_manager_chromeos.cc [modify] https://crrev.com/2aa9dd13b0ba68a0f493c86f80b1bb0f3ceffc41/chrome/browser/chromeos/display/quirks_browsertest.cc [modify] https://crrev.com/2aa9dd13b0ba68a0f493c86f80b1bb0f3ceffc41/chrome/browser/chromeos/policy/device_quirks_policy_browsertest.cc [modify] https://crrev.com/2aa9dd13b0ba68a0f493c86f80b1bb0f3ceffc41/components/quirks/quirks_client.cc [modify] https://crrev.com/2aa9dd13b0ba68a0f493c86f80b1bb0f3ceffc41/components/quirks/quirks_client.h [modify] https://crrev.com/2aa9dd13b0ba68a0f493c86f80b1bb0f3ceffc41/components/quirks/quirks_manager.cc [modify] https://crrev.com/2aa9dd13b0ba68a0f493c86f80b1bb0f3ceffc41/components/quirks/quirks_manager.h
,
Mar 17 2017
,
Mar 17 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 21 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6430db27258ef171500a8e58c82a24459ccefd0f commit 6430db27258ef171500a8e58c82a24459ccefd0f Author: glevin <glevin@chromium.org> Date: Tue Mar 21 17:09:24 2017 Include display names in Quirks URL BUG= 667416 TEST=Enable VLOGing for Quirks, plug in an external display, check log, verify that Quirks URL includes display name (roughly the same name as seen in display settings for 2nd monitor). Review-Url: https://codereview.chromium.org/2746443002 Cr-Commit-Position: refs/heads/master@{#457551} (cherry picked from commit 2aa9dd13b0ba68a0f493c86f80b1bb0f3ceffc41) Review-Url: https://codereview.chromium.org/2765703003 . Cr-Commit-Position: refs/branch-heads/3029@{#335} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/6430db27258ef171500a8e58c82a24459ccefd0f/ash/display/display_color_manager_chromeos.cc [modify] https://crrev.com/6430db27258ef171500a8e58c82a24459ccefd0f/chrome/browser/chromeos/display/quirks_browsertest.cc [modify] https://crrev.com/6430db27258ef171500a8e58c82a24459ccefd0f/chrome/browser/chromeos/policy/device_quirks_policy_browsertest.cc [modify] https://crrev.com/6430db27258ef171500a8e58c82a24459ccefd0f/components/quirks/quirks_client.cc [modify] https://crrev.com/6430db27258ef171500a8e58c82a24459ccefd0f/components/quirks/quirks_client.h [modify] https://crrev.com/6430db27258ef171500a8e58c82a24459ccefd0f/components/quirks/quirks_manager.cc [modify] https://crrev.com/6430db27258ef171500a8e58c82a24459ccefd0f/components/quirks/quirks_manager.h
,
Mar 21 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tbuck...@chromium.org
, Feb 7 2017