New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667414 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Unable to abandon CLs

Project Member Reported by moch@chromium.org, Nov 21 2016

Issue description

Please fill out the relevant section and delete the others.

We are unable to abandon CLs in the following repo:

chromiumos/overlays/chromiumos-overlays

Example CLs given below (note that they were abandoned by dnj@ on request, but we'd like to be able to do it going forward).

https://chromium-review.googlesource.com/#/c/404048/
https://chromium-review.googlesource.com/#/c/404028/
https://chromium-review.googlesource.com/#/c/384305/
 

Comment 1 by moch@chromium.org, Nov 21 2016

Please ensure that philipchen@, yueherngl@ and moch@ have abandon permissions for this repo.

Comment 2 by benhenry@google.com, Nov 21 2016

Labels: Pri-2

Comment 3 by agable@google.com, Nov 21 2016

Owner: davidjames@chromium.org
Status: Assigned (was: Untriaged)
The group chromiumos-owners[1] can grant you any permissions you need on repos in the chromiumos/ subtree. I'm assigning this to one of them to make the decision about how they want to manage their repository permissions.

In the mean time, however, note that CLs can always be abandoned by their owner. Please consider upgrading the script which runs as partner-android-build@google.com to also abandon changes which have been marked CR-2.

[1] https://chromium-review.googlesource.com/#/admin/groups/uuid-f9035f7f62928b3b6813207f7779d50d8858afe8

Comment 4 by moch@chromium.org, Nov 21 2016

Cc: jinsong@chromium.org
+ jinsong - can we update the scripts to abandon CLs that have been marked as CR-2
Owner: shuqianz@chromium.org
Owner: akes...@chromium.org
I don't have the privilege to grant this kind of permission I think. Assign to akeshet@, who probably has.
What exactly is being asked for any why?

Comment 8 by moch@chromium.org, Nov 21 2016

In general we are requesting to permission to be able to abandon CLs in chromiumos/overlays/chromiumos-overlays repo.

We are working to automate CL generation for new devices. Once in a while we need all the other CLs that are generated but need to abandon the one that is generated in this repo (not too often so doesn't make sense to change the automation logic).

On other occasions we have pending CLs from partners who have left and we are unable to abandon their CLs. 
Do you already have +2 and commit access? I'm not sure exactly how Abandon permission works by default. Is the problem that you can't abandon your own CLs, or that you can't abandon other people's CLs?

Comment 10 by jinsong@google.com, Nov 21 2016

YH, have you tried to abandon CL
https://chromium-review.googlesource.com/#/c/404048/
which show you as author and committer? 


Comment 11 by moch@chromium.org, Nov 21 2016

Aviv, we have +2 and commit access on that repo. These are CLs generated by a bot as part of an automation effort.

Jinsong, YH was unable to abandon that CL. Hence it was abandoned by dnj@
@Jinsong, I'm just reviewer of that CL, but not the owner.

Is there still action required on this bug?

Comment 14 by moch@chromium.org, Nov 29 2016

Yes, we need the right ACLs to enable us to abandon CLs such as those in c#0 
Cc: vapier@chromium.org sosa@chromium.org
http://google3/third_party/java_src/gerritcodereview/gerrit/Documentation/access-control.txt indicates that the Abandon permission allows users to abandon CLs that they do not own.

To get back to the request here --  are there people who want this ability who are not already committers (i.e. able to +2 changes?)

I am tempted to just universally allow +2 committers to Abandon CLs. This means any chromiumos committer would be able to abandon CLs by other authors on chromiumos repos, whereas today people can only abandon their own CL (unless they are a repo-wide owner or gerrit admin).

+vapier +sosa for comment whether they love or hate that thought.
Labels: -Restrict-View-Google OS-Chrome Type-Feature
i think allowing anyone who has +2 to also abandon any CL is fine.  it's not a destructive operation -- you can easily restore a CL if desired.  it's also not like someone with +2 couldn't -2 or -1(verified) your CL which is largely equiv in its "destructiveness".
Status: Fixed (was: Assigned)
Should be fixed (on external gerrit).
Status: Verified (was: Fixed)
Thanks I can see the "Abandon" button now (for which I'm not the owner).

Sign in to add a comment