New issue
Advanced search Search tips

Issue 667404 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: ----
Type: ----



Sign in to add a comment

paint/invalidation/video-unmute-repaint.html failing on chromium.webkit/WebKit Win7 (dbg)

Project Member Reported by piman@chromium.org, Nov 21 2016

Issue description

webkit_tests failing on chromium.webkit/WebKit Win7 (dbg)

Type: build-failure

Builders failed on: 
- WebKit Win7 (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29



 

Comment 1 by piman@chromium.org, Nov 21 2016

Labels: OS-Windows
Summary: paint/invalidation/video-unmute-repaint.html failing on chromium.webkit/WebKit Win7 (dbg) (was: webkit_tests failing on chromium.webkit/WebKit Win7 (dbg))
Seems like a consistent failure. First failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/8165

Looks like a blinking cursor diff. Nothing obvious in the logs...

Comment 2 by piman@chromium.org, Nov 21 2016

Err, never mind the blinking cursor diff. Wrong bug.

Comment 4 by piman@chromium.org, Nov 21 2016

Owner: wangxianzhu@chromium.org
@wangxianzhu : any idea?
Components: Blink>Paint>Invalidation Blink>Media>Video
Status: Assigned (was: Untriaged)
This looks like under-invalidation of buffered range of the video ( bug 484288 ). Our current resolution is to allow the under-invalidation in a short time, so the situation the test encountered should be valid. Will disable under-invalidation checking for the test.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3184e441e689e84c4aa367e9ac514c22bdb6145

commit b3184e441e689e84c4aa367e9ac514c22bdb6145
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Tue Nov 22 01:49:51 2016

Disable under-invalidation checking in two video paint invalidation tests

Because of lacking of real-time notification of buffered ranges, we
allow short period of under-invalidation of buffered ranges for good
perfomance and code simplicity. See  crbug.com/484288 .

Disable under-invalidation checking for the two tests which don't
play the video and encountered under-invalidation.

BUG= 667404 

Review-Url: https://codereview.chromium.org/2524463003
Cr-Commit-Position: refs/heads/master@{#433736}

[modify] https://crrev.com/b3184e441e689e84c4aa367e9ac514c22bdb6145/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint.html
[modify] https://crrev.com/b3184e441e689e84c4aa367e9ac514c22bdb6145/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint.html

Comment 7 by piman@chromium.org, Nov 22 2016

Status: Fixed (was: Assigned)

Sign in to add a comment