CUPS printing UI crashes in Guest mode |
|||||||
Issue descriptionSteps: 1. Enter guest mode 2. Enable CUPS (chrome://flags) 3. chrome://md-settings 4. Navigate to, and click on Printers 5. Chrome crashes I've tested the latest M56 canary, but not M57. Prior feedback report: https://feedback.corp.google.com/#/Report/16303985853
,
Nov 21 2016
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/194dc32cac75a954d252d0a1b8ea4aa81eccd8ec commit 194dc32cac75a954d252d0a1b8ea4aa81eccd8ec Author: xdai <xdai@chromium.org> Date: Wed Nov 30 18:24:03 2016 [CUPS] Fix the browser crash in CUPS settings UI in guest mode. The reason for the crash is that there is no PrinterPrefManager keyed service for the guest profile or incognito profile. In order to fix this, we only allow a regular profile to access the CUPS printers settings UI. BUG= 667395 Review-Url: https://codereview.chromium.org/2535303003 Cr-Commit-Position: refs/heads/master@{#435342} [modify] https://crrev.com/194dc32cac75a954d252d0a1b8ea4aa81eccd8ec/chrome/browser/chromeos/printing/printer_pref_manager_factory.cc [modify] https://crrev.com/194dc32cac75a954d252d0a1b8ea4aa81eccd8ec/chrome/browser/ui/webui/options/browser_options_handler.cc [modify] https://crrev.com/194dc32cac75a954d252d0a1b8ea4aa81eccd8ec/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Nov 30 2016
Thanks for the fix. I'll need to make sure that PrintPreview doesn't crash as well. I think we'll want zeroconf printing in guest mode eventually. I've filed crbug.com/669998 so we don't lose it.
,
Nov 30 2016
Thanks. I'll close this issue then.
,
Dec 1 2016
Issue 662184 has been merged into this issue.
,
Jan 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20377bfe446fac2c6e8e6db8ff753b7995bf932b commit 20377bfe446fac2c6e8e6db8ff753b7995bf932b Author: skau <skau@chromium.org> Date: Fri Jan 06 17:52:29 2017 Revert "[CUPS] Fix the browser crash in CUPS settings UI in guest mode." This reverts commit 194dc32cac75a954d252d0a1b8ea4aa81eccd8ec. With https://codereview.chromium.org/2610373003/ enabling printing in incognito, we can reenable printer setup in Guest Mode. BUG= 667395 Review-Url: https://codereview.chromium.org/2616003002 Cr-Commit-Position: refs/heads/master@{#441972} [modify] https://crrev.com/20377bfe446fac2c6e8e6db8ff753b7995bf932b/chrome/browser/chromeos/printing/printer_pref_manager_factory.cc [modify] https://crrev.com/20377bfe446fac2c6e8e6db8ff753b7995bf932b/chrome/browser/ui/webui/options/browser_options_handler.cc [modify] https://crrev.com/20377bfe446fac2c6e8e6db8ff753b7995bf932b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by weifangsun@chromium.org
, Nov 21 2016Owner: x...@chromium.org
Status: Assigned (was: Untriaged)