New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667395 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

CUPS printing UI crashes in Guest mode

Project Member Reported by briannorris@chromium.org, Nov 21 2016

Issue description

Steps:

1. Enter guest mode
2. Enable CUPS (chrome://flags)
3. chrome://md-settings
4. Navigate to, and click on Printers
5. Chrome crashes

I've tested the latest M56 canary, but not M57.

Prior feedback report:

https://feedback.corp.google.com/#/Report/16303985853
 
Cc: -x...@chromium.org weifangsun@chromium.org skau@chromium.org adlr@chromium.org
Owner: x...@chromium.org
Status: Assigned (was: Untriaged)
Labels: Week-1647
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/194dc32cac75a954d252d0a1b8ea4aa81eccd8ec

commit 194dc32cac75a954d252d0a1b8ea4aa81eccd8ec
Author: xdai <xdai@chromium.org>
Date: Wed Nov 30 18:24:03 2016

[CUPS] Fix the browser crash in CUPS settings UI in guest mode.

The reason for the crash is that there is no PrinterPrefManager
keyed service for the guest profile or incognito profile. In order
to fix this, we only allow a regular profile to access the CUPS
printers settings UI.

BUG= 667395 

Review-Url: https://codereview.chromium.org/2535303003
Cr-Commit-Position: refs/heads/master@{#435342}

[modify] https://crrev.com/194dc32cac75a954d252d0a1b8ea4aa81eccd8ec/chrome/browser/chromeos/printing/printer_pref_manager_factory.cc
[modify] https://crrev.com/194dc32cac75a954d252d0a1b8ea4aa81eccd8ec/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/194dc32cac75a954d252d0a1b8ea4aa81eccd8ec/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 4 by skau@chromium.org, Nov 30 2016

Thanks for the fix.  I'll need to make sure that PrintPreview doesn't crash as well.

I think we'll want zeroconf printing in guest mode eventually.  I've filed crbug.com/669998 so we don't lose it.

Comment 5 by x...@chromium.org, Nov 30 2016

Status: Fixed (was: Assigned)
Thanks. I'll close this issue then.

Comment 6 by x...@chromium.org, Dec 1 2016

Cc: x...@chromium.org justincarlson@chromium.org
Issue 662184 has been merged into this issue.

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment