New issue
Advanced search Search tips

Issue 667393 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ReportStage gives wrong build name for trybot-produced images

Project Member Reported by akes...@chromium.org, Nov 21 2016

Issue description

Example: https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/paladin/1665


Expected:
Under ReportStage, expect that the text given would read:
Artifacts[trybot-guado_moblab-paladin/R57-9009.0.0-b1665]

Actual:
Text reads:
Artifacts[guado_moblab-paladin/R57-9009.0.0-b1665]


This is the incorrect "build name" for the artifacts that were actually produced. (e.g. if I try to run run_suite -i guado_moblab-paladin/R57-9009.0.0-b1665 it will not work)
 
Owner: dgarr...@chromium.org
Status: Assigned (was: Untriaged)
I think this was probably broken by some of the work that Don was doing.

Comment 2 by autumn@chromium.org, Nov 29 2016

Labels: -current-issue
Interesting. It's using the build config name, but we appear to munge that when uploading artifacts from trybots.
Still seeing this. Is this easy to fix?
Maybe if we rename the config during trybot munging? But then we have to consistently use the new name, not the original one.
https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/paladin/2940

This is still happening. I have to work around it every time I try to run hardware tests against a trybot-produced image.

Seems like it should be a simple fix. Can you take a look?


Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/63831d08aebeaa4b1142655ecc341692ff102de7

commit 63831d08aebeaa4b1142655ecc341692ff102de7
Author: Don Garrett <dgarrett@google.com>
Date: Wed Mar 21 22:55:42 2018

archive_lib: Stop appending trybot- for tryjobs.

Up until now, a build config name could be reused for both production
and tryjob builds, but that's no longer true, so we don't need to
munge our upload URLs to keep the two results distinct.

BUG= chromium:667393 
TEST=run_tests

Change-Id: I39dc488502363578a267e08061a4f8612bd9c727
Reviewed-on: https://chromium-review.googlesource.com/965607
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/63831d08aebeaa4b1142655ecc341692ff102de7/cbuildbot/cbuildbot_run.py
[modify] https://crrev.com/63831d08aebeaa4b1142655ecc341692ff102de7/lib/config_lib.py
[modify] https://crrev.com/63831d08aebeaa4b1142655ecc341692ff102de7/cbuildbot/archive_lib_unittest.py
[modify] https://crrev.com/63831d08aebeaa4b1142655ecc341692ff102de7/cbuildbot/archive_lib.py

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d000ba8fdded914995828078611e361e96f7d722

commit d000ba8fdded914995828078611e361e96f7d722
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Mar 22 03:25:05 2018

Roll src/third_party/chromite/ 1d37d531d..8bf5a7243 (3 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1d37d531d536..8bf5a724397c

$ git log 1d37d531d..8bf5a7243 --date=short --no-merges --format='%ad %ae %s'
2018-03-20 manojgupta cbuildbot: Only build virtual/target-fuzzers for fuzzer builders.
2018-03-15 dgarrett archive_lib: Stop appending trybot- for tryjobs.
2018-03-21 dgarrett precq_launcher: Fix swarming PreCQ hack.

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:823787 , chromium:667393 , chromium:823445 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7abe614767178c4d769dd22efaa488e7e6e9083e
Reviewed-on: https://chromium-review.googlesource.com/974743
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544964}
[modify] https://crrev.com/d000ba8fdded914995828078611e361e96f7d722/DEPS

Sign in to add a comment