Issue metadata
Sign in to add a comment
|
SB Scout: text alignment |
||||||||||||||||||||||||
Issue descriptionWe're not sure about text alignment of the scout string per ui-review:https://groups.google.com/a/google.com/forum/#!topic/chrome-ui-review/k-UdT8JU6qc This question applies to both: * the settings page (vertical alignment of the check box) * the interstitial (positioning under the check box) +Alan, could you let us know what is correct? After, please assign to +lpz to fix.
,
Dec 2 2016
,
Dec 9 2016
This is blocking ui-review which is blocking launch review for M56.
,
Dec 12 2016
+cc bettes Quick update: I fiddled with this but wasn't successful in fixing the alignment. Reaching out to some experts for help this week.
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a96c732633fe3292aed488f7bfcc3b31a05794c1 commit a96c732633fe3292aed488f7bfcc3b31a05794c1 Author: lpz <lpz@chromium.org> Date: Thu Dec 15 16:35:53 2016 Make the extended reporting opt-in checkbox into a flexbox. This makes multi-line labels left align with themselves instead of wrap underneath the checkbox. BUG= 667389 Review-Url: https://codereview.chromium.org/2566983005 Cr-Commit-Position: refs/heads/master@{#438847} [modify] https://crrev.com/a96c732633fe3292aed488f7bfcc3b31a05794c1/components/security_interstitials/core/browser/resources/interstitial_v2.css [modify] https://crrev.com/a96c732633fe3292aed488f7bfcc3b31a05794c1/components/security_interstitials/core/browser/resources/interstitial_v2.html
,
Dec 15 2016
,
Dec 16 2016
Can you confirm that this was merged to 56?
,
Dec 16 2016
It wasn't merged into 56. I was waiting for the commit to make it into canary but it appears that didn't happen last night (https://storage.googleapis.com/chromium-find-releases-static/a96.html#a96c732633fe3292aed488f7bfcc3b31a05794c1). Also, looks like we're outside of the beta window for 56 now. Sounds like there's a final opportunity to get critical fixes into 56, but I'm not sure this one meets the bar? I'll ask the release team what they think.
,
Dec 16 2016
Adding merge request label (which may be processed after the holidays). This issue blocks ui-review and launch review for 56.
,
Dec 16 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd7e39ed3eb7005a36c6b980fd2dbe8762d1c04d commit fd7e39ed3eb7005a36c6b980fd2dbe8762d1c04d Author: Nathan Parker <nparker@chromium.org> Date: Fri Dec 16 17:21:21 2016 [Merge M56] Make the extended reporting opt-in checkbox into a flexbox. This makes multi-line labels left align with themselves instead of wrap underneath the checkbox. BUG= 667389 Review-Url: https://codereview.chromium.org/2566983005 Cr-Commit-Position: refs/heads/master@{#438847} (cherry picked from commit a96c732633fe3292aed488f7bfcc3b31a05794c1) Review-Url: https://codereview.chromium.org/2584893003 . Cr-Commit-Position: refs/branch-heads/2924@{#527} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/fd7e39ed3eb7005a36c6b980fd2dbe8762d1c04d/components/security_interstitials/core/browser/resources/interstitial_v2.css [modify] https://crrev.com/fd7e39ed3eb7005a36c6b980fd2dbe8762d1c04d/components/security_interstitials/core/browser/resources/interstitial_v2.html
,
Jan 4 2017
Tested on Mac OS 10.12.2 using chrome Beta M56 #56.0.2924.51 and followed steps: 1. Navigated to url "https://expired.badssl.com/" and observed. Attached screenshots of M55 #55.0.2883.87 and M56 #56.0.2924.51 . @Ipz--Could you please check if the issue is fixed or could you please provide the steps to verify the issue. Thanks!
,
Jan 5 2017
,
Jan 5 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bettes@chromium.org
, Nov 28 201639.8 KB
39.8 KB View Download