Scout: change what words are linked in string |
||||||
Issue descriptionPrivacy whitepaper should be linked to "system information and page content" instead of "send" per ui-review: https://groups.google.com/a/google.com/forum/#!topic/chrome-ui-review/k-UdT8JU6qc
,
Nov 22 2016
,
Nov 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/762fb54cd325ae2f557a3a8f9199daa480f8f8b7 commit 762fb54cd325ae2f557a3a8f9199daa480f8f8b7 Author: jialiul <jialiul@chromium.org> Date: Fri Nov 25 20:43:12 2016 Fix privacy whitepaper link on safe browsing blocking page and captive portal bloking page (whitepaper links on other interstitials are fine). Link privacy whitepaper to "system information and page content" instead of "Automatically send" on Scout opt-in string. BUG= 667823 , 667385 Review-Url: https://codereview.chromium.org/2526543002 Cr-Commit-Position: refs/heads/master@{#434546} [modify] https://crrev.com/762fb54cd325ae2f557a3a8f9199daa480f8f8b7/chrome/app/generated_resources.grd [modify] https://crrev.com/762fb54cd325ae2f557a3a8f9199daa480f8f8b7/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc [modify] https://crrev.com/762fb54cd325ae2f557a3a8f9199daa480f8f8b7/chrome/browser/ssl/captive_portal_blocking_page.cc
,
Nov 25 2016
,
Nov 30 2016
Request merge into M56 based on UX review.
,
Nov 30 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff1ef44692a1b71e31d366790ad8cd3abf3615ca commit ff1ef44692a1b71e31d366790ad8cd3abf3615ca Author: Jialiu Lin <jialiul@chromium.org> Date: Wed Nov 30 22:52:48 2016 Fix privacy whitepaper link on safe browsing blocking page and captive portal bloking page (whitepaper links on other interstitials are fine). Link privacy whitepaper to "system information and page content" instead of "Automatically send" on Scout opt-in string. BUG= 667823 , 667385 Review-Url: https://codereview.chromium.org/2526543002 Cr-Commit-Position: refs/heads/master@{#434546} (cherry picked from commit 762fb54cd325ae2f557a3a8f9199daa480f8f8b7) Review URL: https://codereview.chromium.org/2540243003 . Cr-Commit-Position: refs/branch-heads/2924@{#219} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/ff1ef44692a1b71e31d366790ad8cd3abf3615ca/chrome/app/generated_resources.grd [modify] https://crrev.com/ff1ef44692a1b71e31d366790ad8cd3abf3615ca/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc [modify] https://crrev.com/ff1ef44692a1b71e31d366790ad8cd3abf3615ca/chrome/browser/ssl/captive_portal_blocking_page.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jialiul@chromium.org
, Nov 22 2016Owner: jialiul@chromium.org
Status: Assigned (was: Untriaged)