Can't provide a Code-Review score for CLs in tools/build |
||||||
Issue descriptionI used to be able to stamp things in tools/build (and indeed am an OWNER for master.chromium.perf and master.chromium.perf.fyi) but now it seems like I can't vote on a Code-Review score, e.g. in https://chromium-review.googlesource.com/c/412502/ If you use the legacy UI, the tooltips when you hover over reviewers' names show you the voting privileges people have; Emily and I seem to only have Commit-Queue but stip has both Code-Review and Commit-Queue. When I click the reply button, I see no radio buttons for Code-Review, only Commit-Queue.
,
Nov 21 2016
,
Nov 21 2016
,
Nov 21 2016
Yes, this is due to the lack of sync between chrome-infra-auth (which provided the groups backend for CQ, which was the only thing checking permissions on Rietveld) and Gerrit, which proactively checks permissions before CQ even has to. You are a member of build-master-owners, which gets inherited into project-infra-committers, so that your LGTMs are counted by the CQ. Unfortunately, only the latter group (and not the inheritance of build-master-owners) is currently sync'd. We're working on fixing this. Blocking on tracking issue.
,
Nov 21 2016
,
Jan 18 2017
Ping - please provide an update to your high priority bug. This bug is stale. Is it really P-1?
,
Apr 5 2017
The blocking issue has been fixed, and this should be fixed as well. We've also improved the UI messaging when you don't have sufficient privs to set a label. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by martiniss@chromium.org
, Nov 21 2016