New issue
Advanced search Search tips

Issue 667376 link

Starred by 1 user
Status: Fixed
Owner:
jsb...@chromium.org
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 655479



Sign in to add a comment

WPT imported service-workers/cache-storage/window/cache-match.https.html logs server header

Project Member Reported by jsb...@chromium.org, Nov 21 2016 
Test fails with assertion:

FAIL Cache.match with Request and Response objects with different URLs assert_array_equals: Cache.match should return a Response object that has the same properties as the stored response. Headers differ. property 1, expected "content-type: text/plain" but got "server: BaseHTTP/0.3 Python/2.7.3"

Note that the python version varies across our bots, so it's necessary to have a [Pass Failure] expectation

Comment 1 by jsb...@chromium.org, Nov 21 2016 

imported/wpt/service-workers/cache-storage/window/cache-put.https.html too
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80cc8049a86123976cc7255f2bcd689322f596bf

commit 80cc8049a86123976cc7255f2bcd689322f596bf
Author: jsbell <jsbell@chromium.org>
Date: Mon Nov 21 21:11:32 2016

Import wpt@5a1f188e0536ad023936cc62f9a00617299dc192

Using update-w3c-deps in Chromium 2040bff2a904885249b1d58f3950b80ae45ebcbd.

Imports the service-workers/cache-storage as well as recent upstream changes.

BUG= 666991 ,666993,432746, 667376 

Review-Url: https://codereview.chromium.org/2517743002
Cr-Commit-Position: refs/heads/master@{#433651}

[modify] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/W3CImportExpectations
[delete] https://crrev.com/d4c7abab4259e2aba07659b3f71b288ff61ccec6/third_party/WebKit/LayoutTests/imported/wpt/DOM-parsing/todo/internalSubset.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/historical.html
[modify] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/interfaces-expected.txt
[modify] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/interfaces.html
[modify] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/interfaces.idl
[modify] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/interfaces.worker.js
[modify] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/MANIFEST.json
[delete] https://crrev.com/d4c7abab4259e2aba07659b3f71b288ff61ccec6/third_party/WebKit/LayoutTests/imported/wpt/bluetooth/bluetooth-helpers.js
[delete] https://crrev.com/d4c7abab4259e2aba07659b3f71b288ff61ccec6/third_party/WebKit/LayoutTests/imported/wpt/console/console-is-a-namespace.any.js
[delete] https://crrev.com/d4c7abab4259e2aba07659b3f71b288ff61ccec6/third_party/WebKit/LayoutTests/imported/wpt/dpub-aam/README.md
[delete] https://crrev.com/d4c7abab4259e2aba07659b3f71b288ff61ccec6/third_party/WebKit/LayoutTests/imported/wpt/dpub-aria/README.md
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/resetting-a-form/reset-event.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/idle-callbacks/basic.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/idle-callbacks/callback-idle-periods.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/idle-callbacks/callback-timeout-with-raf.html
[delete] https://crrev.com/d4c7abab4259e2aba07659b3f71b288ff61ccec6/third_party/WebKit/LayoutTests/imported/wpt/mediacapture-record/BlobEvent-constructor.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/common.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/blank.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/common-worker.js
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/credentials-iframe.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/credentials-worker.js
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/fetch-status.py
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/iframe.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/simple.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/test-helpers.js
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/testharness-helpers.js
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-add.js
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-delete.js
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-match.js
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-matchAll.js
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-put.js
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-storage-keys.js
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-storage-match.js
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-storage.js
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-add.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-delete.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-match.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-matchAll.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-put.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-storage-keys.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-storage-match.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-storage.https-expected.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-storage.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/credentials-expected.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/credentials.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-add.https-expected.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-add.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-delete.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-match.https-expected.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-match.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-matchAll.https-expected.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-matchAll.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-put.https-expected.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-put.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-storage-keys.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-storage-match.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-storage.https-expected.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-storage.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/sandboxed-iframes.https-expected.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/sandboxed-iframes.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-add.https-expected.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-add.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-delete.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-match.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-matchAll.https-expected.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-matchAll.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-put.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-storage-keys.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-storage-match.https.html
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-storage.https-expected.txt
[add] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-storage.https.html
[delete] https://crrev.com/d4c7abab4259e2aba07659b3f71b288ff61ccec6/third_party/WebKit/LayoutTests/imported/wpt/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/test-009-expected.txt
[modify] https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf/third_party/WebKit/LayoutTests/imported/wpt/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/test-009.html
[delete] https://crrev.com/d4c7abab4259e2aba07659b3f71b288ff61ccec6/third_party/WebKit/LayoutTests/imported/wpt/wai-aria/README.md

Comment 3 by jsb...@chromium.org, Nov 21 2016

Blocking: 655479

Comment 4 by jsb...@chromium.org, Nov 30 2016 

The assertions used in the test are pretty terrible[1] but it also doesn't look like we implement the "sort and combine" logic from the spec to ensure that the headers appear in consistent order when iterating [2], [3]


[1] https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/override_assert_object_equals.js?dr&q=assert_response_equals&sq=package:chromium&l=31
[2] https://fetch.spec.whatwg.org/#headers
[3] https://fetch.spec.whatwg.org/#concept-header-list-sort-and-combine

Comment 5 by jsb...@chromium.org, Dec 1 2016

Owner: jsb...@chromium.org
Status: Staretd (was: Untriaged)

Comment 6 by jsb...@chromium.org, Dec 1 2016

Status: Started (was: Staretd)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abbafbc0bacfca5beada1e3d1a5299569e0a5262

commit abbafbc0bacfca5beada1e3d1a5299569e0a5262
Author: jsbell <jsbell@chromium.org>
Date: Sat Dec 03 02:33:10 2016

Sort headers for iteration

Fetch requires [1] that "the value pairs to iterate over are the
return value of running sort and combine with the header list", which
is to say we don't simply iterate over the internal data of Headers
but make a sorted (and combined) copy [2]. This manifested in some
failing imported cache tests that were sensitive to the order.

This CL implements making a copy and sorting the list for iteration;
it does not implement combining[3]. So not perfect but an incremental
improvement.

[1] https://fetch.spec.whatwg.org/#headers-class
[2] https://fetch.spec.whatwg.org/#concept-header-list-sort-and-combine
[3] https://fetch.spec.whatwg.org/#concept-header-value-combined

BUG= 667376 , 670439 
R=yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2542073005
Cr-Commit-Position: refs/heads/master@{#436147}

[modify] https://crrev.com/abbafbc0bacfca5beada1e3d1a5299569e0a5262/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/abbafbc0bacfca5beada1e3d1a5299569e0a5262/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js
[delete] https://crrev.com/5190330169f1e6c1d8418e6bcc0499fdc99ec287/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-match.https-expected.txt
[delete] https://crrev.com/5190330169f1e6c1d8418e6bcc0499fdc99ec287/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-put.https-expected.txt
[modify] https://crrev.com/abbafbc0bacfca5beada1e3d1a5299569e0a5262/third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp
[modify] https://crrev.com/abbafbc0bacfca5beada1e3d1a5299569e0a5262/third_party/WebKit/Source/modules/fetch/FetchHeaderList.h
[modify] https://crrev.com/abbafbc0bacfca5beada1e3d1a5299569e0a5262/third_party/WebKit/Source/modules/fetch/Headers.cpp
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da6e2412d9e3547954e1196c3b8d523be7090df6

commit da6e2412d9e3547954e1196c3b8d523be7090df6
Author: corona10 <corona10@gmail.com>
Date: Wed Dec 14 20:47:27 2016

[Fetch API] Implement combining of Headers for same keys.

Currently FetchHeaderList::sortAndCombine() only sorts the list and does not
combine values for the same key. This CL implements the missing part in the
function.

BUG= 670439 ,  667376 

Review-Url: https://codereview.chromium.org/2559273005
Cr-Commit-Position: refs/heads/master@{#438615}

[modify] https://crrev.com/da6e2412d9e3547954e1196c3b8d523be7090df6/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js
[modify] https://crrev.com/da6e2412d9e3547954e1196c3b8d523be7090df6/third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp

Comment 9 by jsb...@chromium.org, Jan 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment