New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 667361 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Dec 2016
Cc:
█ imch...@chromium.org
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router] Dialog shows device list instead of media controls while casting

Project Member Reported by taku...@chromium.org, Nov 21 2016 
Initially reported at b/32877879.

While casting, opening the dialog sometimes shows the sink list instead of the details view. Reproducible on non-debug builds of M55 and M56, but not on debug builds. It seems to be due to a race condition in which MediaRouterWebUIMessageHandler::SetInitialData() is sometimes called before MediaRouterUI::OnRoutesUpdated().

Comment 1 by sko...@chromium.org, Dec 1 2016

Labels: -M-56 M-57
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21ad18d7d165fe60792c5c5e3c56b0647324c03c

commit 21ad18d7d165fe60792c5c5e3c56b0647324c03c
Author: takumif <takumif@chromium.org>
Date: Mon Dec 05 18:50:04 2016

Add GetCurrentRoutes() to MediaRouter API, ensure dialog has routes at init

This CL adds a method to the MediaRouter interface to get the current media
routes synchronously. We call this if MediaRouterUI hasn't observed routes
updates yet when the dialog WebUI asks for initial data, to ensure that WebUI
has routes information at initialization.

BUG= 667361 

Review-Url: https://codereview.chromium.org/2540773005
Cr-Commit-Position: refs/heads/master@{#436366}

[modify] https://crrev.com/21ad18d7d165fe60792c5c5e3c56b0647324c03c/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/21ad18d7d165fe60792c5c5e3c56b0647324c03c/chrome/browser/media/router/media_router_base.cc
[modify] https://crrev.com/21ad18d7d165fe60792c5c5e3c56b0647324c03c/chrome/browser/media/router/media_router_base.h
[modify] https://crrev.com/21ad18d7d165fe60792c5c5e3c56b0647324c03c/chrome/browser/media/router/media_router_base_unittest.cc
[modify] https://crrev.com/21ad18d7d165fe60792c5c5e3c56b0647324c03c/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/21ad18d7d165fe60792c5c5e3c56b0647324c03c/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/21ad18d7d165fe60792c5c5e3c56b0647324c03c/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/21ad18d7d165fe60792c5c5e3c56b0647324c03c/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/21ad18d7d165fe60792c5c5e3c56b0647324c03c/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

Comment 3 by taku...@chromium.org, Dec 5 2016

Status: Fixed (was: Started)

Comment 4 by taku...@chromium.org, Dec 6 2016

Labels: Merge-Request-56
I'd like to request a merge of #2 to M56.

Comment 5 by dimu@chromium.org, Dec 6 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)

Comment 6 by ligim...@chromium.org, Dec 6 2016 

M56 Beta promotion is scheduled on Dec 8 & RC cut on Wednesday, Dec 7 @ 3.00 PM PST.Please ensure to verify the fix and merge your change ASAP so that we could take it for next Release.

Comment 7 by taku...@chromium.org, Dec 7 2016

Cc: imch...@chromium.org
I've verified the fix in Canary on Windows/Mac.
Derek, could you help me merge this please?
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 7 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56bae1de1137687fc84d8d6f251a196545bb021d

commit 56bae1de1137687fc84d8d6f251a196545bb021d
Author: Derek Cheng <imcheng@chromium.org>
Date: Wed Dec 07 22:28:25 2016

Add GetCurrentRoutes() to MediaRouter API, ensure dialog has routes at init

This CL adds a method to the MediaRouter interface to get the current media
routes synchronously. We call this if MediaRouterUI hasn't observed routes
updates yet when the dialog WebUI asks for initial data, to ensure that WebUI
has routes information at initialization.

BUG= 667361 

Review-Url: https://codereview.chromium.org/2540773005
Cr-Commit-Position: refs/heads/master@{#436366}
(cherry picked from commit 21ad18d7d165fe60792c5c5e3c56b0647324c03c)

Review URL: https://codereview.chromium.org/2558963003 .

Cr-Commit-Position: refs/branch-heads/2924@{#393}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/56bae1de1137687fc84d8d6f251a196545bb021d/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/56bae1de1137687fc84d8d6f251a196545bb021d/chrome/browser/media/router/media_router_base.cc
[modify] https://crrev.com/56bae1de1137687fc84d8d6f251a196545bb021d/chrome/browser/media/router/media_router_base.h
[modify] https://crrev.com/56bae1de1137687fc84d8d6f251a196545bb021d/chrome/browser/media/router/media_router_base_unittest.cc
[modify] https://crrev.com/56bae1de1137687fc84d8d6f251a196545bb021d/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/56bae1de1137687fc84d8d6f251a196545bb021d/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/56bae1de1137687fc84d8d6f251a196545bb021d/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/56bae1de1137687fc84d8d6f251a196545bb021d/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/56bae1de1137687fc84d8d6f251a196545bb021d/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
►

Sign in to add a comment