New issue
Advanced search Search tips

Issue 667353 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

New shipping address should appear in the billing address suggestions.

Project Member Reported by se...@chromium.org, Nov 21 2016

Issue description

^^^

 
Labels: Merge-Request-56

Comment 3 by dimu@chromium.org, Nov 22 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 22 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d21f935754996042c1fae005dae65407d5eec52

commit 2d21f935754996042c1fae005dae65407d5eec52
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Tue Nov 22 14:36:20 2016

[Merge M-56] [Payments] New shipping address should appear in billing address suggest

BUG= 667353 

Review-Url: https://codereview.chromium.org/2514353003
Cr-Commit-Position: refs/heads/master@{#433595}
(cherry picked from commit 4b961830b5d2d1837fb2353374c41d28f02c2086)

Review URL: https://codereview.chromium.org/2518373002 .

Cr-Commit-Position: refs/branch-heads/2924@{#56}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/2d21f935754996042c1fae005dae65407d5eec52/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/2d21f935754996042c1fae005dae65407d5eec52/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d18f10bb2d7cac2bdc4f07d2c5d3b813d9f688a

commit 1d18f10bb2d7cac2bdc4f07d2c5d3b813d9f688a
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Tue Nov 22 15:07:26 2016

[M-56] Define helper constant in payment tests.

This patch fixes compile of Android integration tests. A merge into M-56
of a bug fix with tests was relying on DECEMBER, NEXT_YEAR, and
FIRST_BILLING_ADDRESS to be defined elsewhere, but that definition was
in a patch that does not need to be merged into M-56.

BUG= 667353 
TBR=sebsg@chromium.org

Review URL: https://codereview.chromium.org/2518403002 .

Cr-Commit-Position: refs/branch-heads/2924@{#58}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/1d18f10bb2d7cac2bdc4f07d2c5d3b813d9f688a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment