New issue
Advanced search Search tips

Issue 667346 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner: ----
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.3%-9.4% regression in thread_times.key_silk_cases at 433406:433453

Project Member Reported by mustaq@chromium.org, Nov 21 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 21 2016

Mergedinto: 667258
Status: Duplicate (was: Untriaged)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Pass correct texture hint for GPU raster
Author  : ericrk
Commit description:
  
Currently, ResourcePool creates all resources with
ResourceProvider::TEXTURE_HINT_IMMUTABLE. This is fine for SW raster,
however we should be using TEXTURE_HINT_IMMUTABLE_FRAMEBUFFER for GPU
raster. Using the correct flag passes additional information to ANGLE
via a GL extension and causes us to skip an unnecessary texture copy.

R=vmpstr
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2507963003
Cr-Commit-Position: refs/heads/master@{#433437}
Commit  : da59d418f54604ba2451cd0ef3a9cd42c05ca530
Date    : Sun Nov 20 00:45:40 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N    Good?
chromium@433432  3.45692  19.7794  145  good
chromium@433435  3.47285  19.7753  145  good
chromium@433436  3.48114  20.4046  145  good
chromium@433437  3.75465  22.0174  145  bad    <--
chromium@433441  3.7527   22.0939  145  bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 667346

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests thread_times.key_silk_cases
Test Metric: thread_IO_cpu_time_per_frame/thread_IO_cpu_time_per_frame
Relative Change: 8.56%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/4360
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8995365114696153792


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5784632635686912

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment