We want to use DisplayChangeObserver with mustash. DisplayChangeObserver will need to moved from src/ash/display to src/ui/display and will need to be decoupled from ash.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bfba989d85ca0d33e316802507e2e59b4c756ab commit 7bfba989d85ca0d33e316802507e2e59b4c756ab Author: kylechar <kylechar@chromium.org> Date: Mon Nov 21 20:44:03 2016 Move kInvalidDisplayID to display_constants.h. There are targets that depend on //ui/display just for that constant. There is a smaller target //ui/display/types that is more suitable for this. Move the constant and update all references in src/ui/*. Other references to display::Display::kInvalidDisplayID will be updated in a follow up CL. BUG= 667344 Review-Url: https://codereview.chromium.org/2519993002 Cr-Commit-Position: refs/heads/master@{#433638} [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/BUILD.gn [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/chromeos/display_configurator.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/display.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/display.h [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/fake_display_delegate.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/fake_display_snapshot.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/fake_display_snapshot.h [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/manager/display_layout.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/manager/display_layout_store.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/manager/display_manager.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/manager/display_manager.h [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/manager/display_manager_utilities_unittest.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/manager/managed_display_info.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/test/display_manager_test_api.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/display/types/display_constants.h [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/events/devices/BUILD.gn [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/events/devices/device_data_manager.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/events/gesture_detection/gesture_provider.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/message_center/views/desktop_popup_alignment_delegate.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/ozone/platform/drm/host/drm_window_host.cc [modify] https://crrev.com/7bfba989d85ca0d33e316802507e2e59b4c756ab/ui/views/mus/screen_mus.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc319224de8c68b2584e3bcc99d0b309dd630aab commit bc319224de8c68b2584e3bcc99d0b309dd630aab Author: kylechar <kylechar@chromium.org> Date: Wed Nov 23 00:51:27 2016 Update display::Display::kInvalidDisplayID constant. The constant was moved to ui/display/types/display_constants.h and is now just display::kInvalidDisplayId. Update all references and delete the old constant. BUG= 667344 Review-Url: https://codereview.chromium.org/2523723002 Cr-Commit-Position: refs/heads/master@{#434043} [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/common/wm/window_positioning_utils.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/content/display/screen_orientation_controller_chromeos_unittest.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/display/display_color_manager_chromeos.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/display/display_manager_unittest.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/display/extended_mouse_warp_controller.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/display/screen_ash.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/display/unified_mouse_warp_controller.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/host/ash_window_tree_host_x11.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/mus/property_util.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/root_window_controller.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/root_window_settings.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/system/chromeos/screen_layout_observer.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/test/ash_test_base.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ash/touch/touch_transformer_controller.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/chrome/browser/chromeos/display/display_preferences.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/chrome/browser/ui/ash/chrome_launcher_prefs.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/chrome/browser/ui/webui/options/chromeos/display_overscan_handler.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/services/ui/display/platform_screen_ozone.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/services/ui/display/platform_screen_ozone.h [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/services/ui/public/cpp/window.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/services/ui/ws/platform_display_init_params.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/services/ui/ws/test_utils.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/services/ui/ws/test_utils.h [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/services/ui/ws/user_display_manager.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/services/ui/ws/window_tree.cc [modify] https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab/ui/display/display.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ce955f57b5440e5f75424beb896a4d8c04ce09d commit 3ce955f57b5440e5f75424beb896a4d8c04ce09d Author: kylechar <kylechar@chromium.org> Date: Wed Nov 23 18:39:44 2016 Move touchscreen_util.cc/h from ash to ui. AssociatedTouchscreens() is used by DisplayChangeObserver/DisplayManager and needed for mustash. Remove the minimal ash dependencies in the tests, they weren't actually needed, and move the tests too. BUG= 667344 Review-Url: https://codereview.chromium.org/2520143002 Cr-Commit-Position: refs/heads/master@{#434210} [modify] https://crrev.com/3ce955f57b5440e5f75424beb896a4d8c04ce09d/ash/BUILD.gn [modify] https://crrev.com/3ce955f57b5440e5f75424beb896a4d8c04ce09d/ash/display/display_change_observer_chromeos.cc [modify] https://crrev.com/3ce955f57b5440e5f75424beb896a4d8c04ce09d/ui/display/BUILD.gn [add] https://crrev.com/3ce955f57b5440e5f75424beb896a4d8c04ce09d/ui/display/chromeos/DEPS [rename] https://crrev.com/3ce955f57b5440e5f75424beb896a4d8c04ce09d/ui/display/chromeos/touchscreen_util.cc [rename] https://crrev.com/3ce955f57b5440e5f75424beb896a4d8c04ce09d/ui/display/chromeos/touchscreen_util.h [rename] https://crrev.com/3ce955f57b5440e5f75424beb896a4d8c04ce09d/ui/display/chromeos/touchscreen_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/731f85f9fb45478c87a7e29cc7139c958cde174d commit 731f85f9fb45478c87a7e29cc7139c958cde174d Author: kylechar <kylechar@chromium.org> Date: Thu Dec 01 20:50:46 2016 Split //ui/display and create //ui/display/manager. Split //ui/display so that general display code stays in //ui/display and display management code is now in //ui/display/manager. This is necessary as //ui/base has a dependency on //ui/display and code that is being refactored out of ash has a dependency on //ui/base, forming a cycle. Create //ui/display/manager target. Move the files in src/ui/display/chromeos to src/ui/display/manager/chromeos since they are all related to display management. Update includes and targets for the moved files. BUG= 667344 TBR=sadrul,reveman CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2540313002 Cr-Commit-Position: refs/heads/master@{#435703} [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/BUILD.gn [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/common/test/BUILD.gn [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/common/test/ash_test.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/common/test/ash_test_impl.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/display_animator_chromeos.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/display_change_observer_chromeos.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/display_change_observer_chromeos.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/display_change_observer_chromeos_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/display_color_manager_chromeos.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/display_color_manager_chromeos_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/display_configuration_controller.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/display_error_observer_chromeos.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/display_manager_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/extended_mouse_warp_controller.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/extended_mouse_warp_controller_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/json_converter.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/json_converter_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/mirror_window_controller.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/mouse_cursor_event_filter_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/projecting_observer_chromeos.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/root_window_transformers_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/screen_position_controller_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/unified_mouse_warp_controller.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/display/window_tree_host_manager_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/extended_desktop_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/mus/BUILD.gn [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/shell.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/sticky_keys/sticky_keys_overlay_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/system/chromeos/power/power_event_observer.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/test/ash_test_impl_aura.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/touch/touch_observer_hud.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/touch/touch_transformer_controller.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/wm/dock/docked_window_layout_manager_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/wm/drag_window_resizer_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/wm/immersive_fullscreen_controller_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/wm/power_button_controller.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ash/wm/workspace/workspace_window_resizer_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/chrome/browser/chromeos/dbus/chrome_console_service_provider_delegate.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/chrome/browser/chromeos/dbus/chrome_display_power_service_provider_delegate.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/chrome/browser/chromeos/display/display_preferences.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/chrome/browser/chromeos/display/display_preferences_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/chrome/browser/chromeos/display/output_protection_delegate.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/chrome/browser/chromeos/policy/display_rotation_default_handler_browsertest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/chrome/browser/extensions/BUILD.gn [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/components/arc/BUILD.gn [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/components/arc/power/DEPS [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/components/arc/power/arc_power_bridge.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/components/exo/BUILD.gn [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/components/exo/wayland/BUILD.gn [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/extensions/shell/BUILD.gn [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/extensions/shell/browser/shell_desktop_controller_aura.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/extensions/shell/browser/shell_desktop_controller_aura.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/media/gpu/BUILD.gn [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/media/gpu/DEPS [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/media/gpu/rendering_helper.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/services/ui/display/BUILD.gn [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/services/ui/display/platform_screen_ozone.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/BUILD.gn [delete] https://crrev.com/4cc2259e5139ce40daa4230b25a4ee7183c23d1b/ui/display/chromeos/x11/display_mode_x11.cc [delete] https://crrev.com/4cc2259e5139ce40daa4230b25a4ee7183c23d1b/ui/display/chromeos/x11/display_util_x11.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/display_layout.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/display_layout.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/display_layout_builder.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/display_layout_builder.h [add] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/BUILD.gn [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/DEPS [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/apply_content_protection_task.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/apply_content_protection_task.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/apply_content_protection_task_unittest.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/configure_displays_task.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/configure_displays_task.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/configure_displays_task_unittest.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/display_configurator.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/display_configurator.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/display_configurator_unittest.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/display_layout_manager.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/display_snapshot_virtual.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/display_snapshot_virtual.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/display_util.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/display_util.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/query_content_protection_task.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/query_content_protection_task.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/query_content_protection_task_unittest.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/test/action_logger.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/test/action_logger.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/test/action_logger_util.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/test/action_logger_util.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/test/test_display_layout_manager.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/test/test_display_layout_manager.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/test/test_native_display_delegate.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/test/test_native_display_delegate.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/touchscreen_util.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/touchscreen_util.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/touchscreen_util_unittest.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/update_display_configuration_task.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/update_display_configuration_task.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/update_display_configuration_task_unittest.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/x11/DEPS [add] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/x11/display_mode_x11.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/x11/display_mode_x11.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/x11/display_snapshot_x11.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/x11/display_snapshot_x11.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/x11/display_util_x11.cc [add] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/x11/display_util_x11.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/x11/display_util_x11_unittest.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/x11/native_display_delegate_x11.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/x11/native_display_delegate_x11.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/x11/native_display_event_dispatcher_x11.cc [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/x11/native_display_event_dispatcher_x11.h [rename] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/chromeos/x11/native_display_event_dispatcher_x11_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/display_layout_builder_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/display_layout_store.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/display_layout_unittest.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/display_manager.h [add] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/display_manager_export.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/display_manager_utilities.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/manager/managed_display_info.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/test/display_manager_test_api.cc [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/test/display_manager_test_api.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/win/scaling_util.h [modify] https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d/ui/display/win/screen_win.cc
Is there anything left to be done for this?
Yep, there are two more in review CLs, http://crrev.com/2523873002 and http://crrev.com/2524863003.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98748a534f51488863475326bcc87b510c90df1d commit 98748a534f51488863475326bcc87b510c90df1d Author: kylechar <kylechar@chromium.org> Date: Sat Dec 03 01:33:22 2016 Remove DisplayChangeObserver ash dependencies. Before moving DisplayChangeObserver from src/ash/display to src/ui/display we need to remove all ash dependencies. 1. DisplayManager and DisplayConfigurator are injected instead of getting them from ash::Shell. 2. DCO no longer acts as a ShellObserver for shutdown. Add ShutdownObserver to do this instead. 3. Move display strings from ash to ui. BUG= 667344 Review-Url: https://codereview.chromium.org/2523873002 Cr-Commit-Position: refs/heads/master@{#436129} [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ash/BUILD.gn [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ash/ash_strings.grd [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ash/display/display_change_observer_chromeos.cc [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ash/display/display_change_observer_chromeos.h [add] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ash/display/shutdown_observer_chromeos.cc [add] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ash/display/shutdown_observer_chromeos.h [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ash/display/window_tree_host_manager.h [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ash/shell.cc [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ash/shell.h [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ash/system/chromeos/screen_layout_observer.cc [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ui/display/manager/BUILD.gn [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ui/display/manager/DEPS [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ui/display/manager/display_manager.cc [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ui/display/manager/display_manager.h [modify] https://crrev.com/98748a534f51488863475326bcc87b510c90df1d/ui/strings/ui_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2e4e41bfcf6b36c5e22d9798eb3aafed8e87ae2 commit f2e4e41bfcf6b36c5e22d9798eb3aafed8e87ae2 Author: kylechar <kylechar@chromium.org> Date: Sun Dec 04 04:21:35 2016 Move DisplayChangeObserver + tests from ash to ui. Move DCO + tests from ash to ui. All of the ash dependencies were already removed, so it's mostly just changing the file location and namespace. BUG= 667344 Review-Url: https://codereview.chromium.org/2524863003 Cr-Commit-Position: refs/heads/master@{#436186} [modify] https://crrev.com/f2e4e41bfcf6b36c5e22d9798eb3aafed8e87ae2/ash/BUILD.gn [modify] https://crrev.com/f2e4e41bfcf6b36c5e22d9798eb3aafed8e87ae2/ash/shell.cc [modify] https://crrev.com/f2e4e41bfcf6b36c5e22d9798eb3aafed8e87ae2/ash/shell.h [modify] https://crrev.com/f2e4e41bfcf6b36c5e22d9798eb3aafed8e87ae2/ui/display/BUILD.gn [modify] https://crrev.com/f2e4e41bfcf6b36c5e22d9798eb3aafed8e87ae2/ui/display/manager/BUILD.gn [rename] https://crrev.com/f2e4e41bfcf6b36c5e22d9798eb3aafed8e87ae2/ui/display/manager/chromeos/display_change_observer.cc [rename] https://crrev.com/f2e4e41bfcf6b36c5e22d9798eb3aafed8e87ae2/ui/display/manager/chromeos/display_change_observer.h [rename] https://crrev.com/f2e4e41bfcf6b36c5e22d9798eb3aafed8e87ae2/ui/display/manager/chromeos/display_change_observer_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Nov 21 2016