The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00a360e5ed7d790433b0be74169afa7643324d0d

commit 00a360e5ed7d790433b0be74169afa7643324d0d
Author: zpeng <zpeng@chromium.org>
Date: Mon Nov 21 23:05:02 2016

Reland #2 of Add GN build rules to allow java_assertion_enabler to enable Java asserts.

Reverted by:
https://codereview.chromium.org/2506263003/

Reason for reland:
Fixed failing tests.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@chromium.org,yolandyan@chromium.org
BUG= 666193 , 667337 , 462676 ,665157,665478,667437

Review-Url: https://codereview.chromium.org/2517203002
Cr-Commit-Position: refs/heads/master@{#433681}

[modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/BUILD.gn
[modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewThreadTest.java
[modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/build/android/java_assertion_enabler/BUILD.gn
[modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/build/android/java_assertion_enabler/java/org/chromium/javaassertionenabler/AssertionEnabler.java
[modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/build/config/android/internal_rules.gni
[modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
[modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
[modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/media/midi/java/src/org/chromium/midi/MidiManagerAndroid.java
[modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/third_party/ow2_asm/BUILD.gn

Huh, we are calling
AwBrowserContext awBrowserContext = getBrowserContextOnUiThread();

before setting "mStarted = true" so the mStarted assert inside getBrowserContextOnUiThread() should always fail :). It looks like earlier we would not call getBrowserContextOnUiThread() inside of startChromiumLocked() so we wouldn't hit this problem (and the assert would ensure that we always called startChromiumLocked() first.

The CL that moved getBrowserContextOnUiThread() is
https://codereview.chromium.org/2398433002

Bo, it looks like we can just move "mStarted = true" to before the call to getBrowserContextOnUiThread() inside startChromiumLocked()?

Yeah, I don't see any reason not to just move the mStarted call, we're holding the lock so nothing should be looking at mStarted on any other thread.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f358617731da18371d313590f6300c15f9615843

commit f358617731da18371d313590f6300c15f9615843
Author: boliu <boliu@chromium.org>
Date: Wed Nov 23 18:24:33 2016

aw: Fix mStarted assert

Move setting mStarted up so getBrowserContextOnUiThread don't hit the
assert.

BUG= 667337 

Review-Url: https://codereview.chromium.org/2526873002
Cr-Commit-Position: refs/heads/master@{#434202}

[modify] https://crrev.com/f358617731da18371d313590f6300c15f9615843/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java