Refactor the usage of ShellHandler |
|||||||
Issue descriptionTo use ShellHandler, it is necessary to keep an instance of UtilityProcessMojoClient alive until the result is received. It is possible to hide this complexity because the usage pattern of ShellHandler is always the same: Call one function and expect only one of the 2 callbacks to run once.
,
Nov 23 2016
,
Jan 13 2017
This is a dependency for merging https://chromium.googlesource.com/chromium/src.git/+/444ce88afe130945dae057125d706b789da9282d, which was approved in crbug/648686
,
Jan 13 2017
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e0e4bf593146a779fa9a553833d41a8a065096e commit 5e0e4bf593146a779fa9a553833d41a8a065096e Author: tmartino <tmartino@chromium.org> Date: Fri Jan 13 21:06:55 2017 Add GetIsPinnedToTaskbarState() Adds the more general function to get the pinned state and refactor the 2 usages of ShellHandler. BUG= 667335 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2512553007 Cr-Commit-Position: refs/heads/master@{#434254} (cherry picked from commit a9831524bf640f9a3eb7842e83fe6c4d3d13652e) Review-Url: https://codereview.chromium.org/2633743002 Cr-Commit-Position: refs/branch-heads/2924@{#763} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/5e0e4bf593146a779fa9a553833d41a8a065096e/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc [modify] https://crrev.com/5e0e4bf593146a779fa9a553833d41a8a065096e/chrome/browser/shell_integration_win.cc [modify] https://crrev.com/5e0e4bf593146a779fa9a553833d41a8a065096e/chrome/browser/shell_integration_win.h [modify] https://crrev.com/5e0e4bf593146a779fa9a553833d41a8a065096e/chrome/browser/ui/webui/welcome_win10_handler.cc [modify] https://crrev.com/5e0e4bf593146a779fa9a553833d41a8a065096e/chrome/browser/ui/webui/welcome_win10_handler.h
,
Jan 17 2017
Not seeing any tests in the Cl, wondering whether we can automate to avoid regressions in future.
,
Jan 17 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Nov 23 2016