New issue
Advanced search Search tips

Issue 667332 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

out/gn_Debing/bin/run_chrome_junit_tests does not run tests anymore

Project Member Reported by pkotw...@chromium.org, Nov 21 2016

Issue description

out/gn_Debing/bin/run_chrome_junit_tests does not run tests anymore

Instead of running JUnit tests, the command now prints
"
usage: test_runner.py [-h]
                      {gtest,instrumentation,junit,linker,monkey,perf,python}
"
 
Owner: jbudorick@chromium.org
Status: Assigned (was: Untriaged)
This change seems to have been caused by https://codereview.chromium.org/2502363005/
Status: Started (was: Assigned)
The relevant part there is after what you quoted:

test_runner.py: error: unrecognized arguments: --runtime-deps-path /usr/local/ssd/code/clankium/src/out-gn/Release/gen.runtime/chrome/android/chrome_junit_tests__test_runner_script.runtime_deps

Fix here: https://codereview.chromium.org/2517283002/
Labels: -Pri-3 Pri-1
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/221b734a23bc7ae55b2104346dc34124bbe6d296

commit 221b734a23bc7ae55b2104346dc34124bbe6d296
Author: jbudorick <jbudorick@chromium.org>
Date: Mon Nov 21 20:35:55 2016

[Android] Fix generated junit scripts wrt --runtime-deps-file.

The junit tests don't need to worry about pushing runtime deps to the
device since they don't run on the device.

BUG= 667332 

Review-Url: https://codereview.chromium.org/2517283002
Cr-Commit-Position: refs/heads/master@{#433631}

[modify] https://crrev.com/221b734a23bc7ae55b2104346dc34124bbe6d296/build/config/android/rules.gni

Status: Fixed (was: Started)

Sign in to add a comment