New issue
Advanced search Search tips

Issue 667319 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 660699

Blocking:
issue 669183



Sign in to add a comment

Implement BluetoothRemoteGATTDescriptor reporting for .readValue()

Project Member Reported by dougt@chromium.org, Nov 21 2016

Issue description

In  issue 660699  we implemented BluetoothRemoteGATTDescriptor but did not include any reporting.  This issue tracks BluetoothRemoteGATTDescriptor reporting.
 

Comment 1 by ortuno@chromium.org, Nov 28 2016

Blocking: 669183
Components: Blink>Bluetooth

Comment 2 by dougt@chromium.org, Jan 21 2017

Status: Started (was: Untriaged)
https://codereview.chromium.org/2641173009/

Comment 3 by dougt@chromium.org, Jan 21 2017

Summary: Implement BluetoothRemoteGATTDescriptor reporting for .readValue() (was: Implement BluetoothRemoteGATTDescriptor reporting)
Lets scope this bug for just readValue()
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4848d4718a80dbd05337efca0528fd189a1a56b1

commit 4848d4718a80dbd05337efca0528fd189a1a56b1
Author: dougt <dougt@chromium.org>
Date: Fri Jan 27 11:06:45 2017

Add BluetoothRemoteGATTDescriptor reporting for .readValue().

Similar to reporting for characteristic.readValue(), this cl will add outcome
reporting for descriptor.readValue allowing us to better understand how common
errors in the field happen.

BUG= 667319 

R=

Review-Url: https://codereview.chromium.org/2641173009
Cr-Commit-Position: refs/heads/master@{#446644}

[modify] https://crrev.com/4848d4718a80dbd05337efca0528fd189a1a56b1/content/browser/bluetooth/bluetooth_metrics.cc
[modify] https://crrev.com/4848d4718a80dbd05337efca0528fd189a1a56b1/content/browser/bluetooth/bluetooth_metrics.h
[modify] https://crrev.com/4848d4718a80dbd05337efca0528fd189a1a56b1/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/4848d4718a80dbd05337efca0528fd189a1a56b1/tools/metrics/histograms/histograms.xml

Comment 5 by dougt@chromium.org, Jan 29 2017

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/beca21a195468bfa60a22f18e77de14bd00496b6

commit beca21a195468bfa60a22f18e77de14bd00496b6
Author: dougt <dougt@chromium.org>
Date: Wed Feb 01 16:28:51 2017

Add BluetoothRemoteGATTDescriptor reporting for .writeValue().

Similar to reporting for descriptor.writeValue(), this cl will add outcome
reporting for descriptor.writeValue allowing us to better understand how common errors in the field happen.

BUG= 667319 
R=

Review-Url: https://codereview.chromium.org/2662433003
Cr-Commit-Position: refs/heads/master@{#447533}

[modify] https://crrev.com/beca21a195468bfa60a22f18e77de14bd00496b6/content/browser/bluetooth/bluetooth_metrics.cc
[modify] https://crrev.com/beca21a195468bfa60a22f18e77de14bd00496b6/content/browser/bluetooth/bluetooth_metrics.h
[modify] https://crrev.com/beca21a195468bfa60a22f18e77de14bd00496b6/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/beca21a195468bfa60a22f18e77de14bd00496b6/tools/metrics/histograms/histograms.xml

Sign in to add a comment