New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 667312 link

Starred by 1 user
Status: Fixed
Owner:
█ mge...@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Better documentation for metrics API

Project Member Reported by mge...@chromium.org, Nov 21 2016 
In particular, people seem to not be finding the use of annotations to associate metrics with the original request on their own, so this should be pointed out more clearly. There might be other issues as well.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74b0f71b1e8238aef97966e59782a365a5205459

commit 74b0f71b1e8238aef97966e59782a365a5205459
Author: mgersh <mgersh@chromium.org>
Date: Tue Dec 06 22:46:36 2016

Explain how to associate RequestFinishedInfo with original request

This has been generating the most questions since the feature launched.
Point it out at the top so it's visible without looking at the specific
method which people have had trouble finding.

BUG= 667312 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2560603002
Cr-Commit-Position: refs/heads/master@{#436763}

[modify] https://crrev.com/74b0f71b1e8238aef97966e59782a365a5205459/components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java

Comment 2 by mge...@chromium.org, Dec 6 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment