New issue
Advanced search Search tips

Issue 667290 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 661390
issue 666247



Sign in to add a comment

Add smoketest to ensure swarming named caches are persistent

Project Member Reported by mar...@chromium.org, Nov 21 2016

Issue description

AI:
Modify luci-py/appengine/swarming/local_smoke_test.py to add a new test case that shall do:

- trigger a task that requests a named cache and put something in there
- trigger a second task and ensure the cache is still populated.
- update tools/stat_bot.py wipe_cache() to wipe any named cache.
 

Comment 1 by estaab@chromium.org, Nov 22 2016

Cc: estaab@chromium.org

Comment 2 by mar...@chromium.org, Nov 22 2016

Owner: mar...@chromium.org
Status: Assigned (was: Available)
Will try to do it in a not too distant future.

Comment 3 by mar...@chromium.org, Jan 17 2017

Blocking: 666247

Comment 4 by mar...@chromium.org, Jan 17 2017

Labels: -Pri-3 -OS-Mac Pri-2
Status: Started (was: Assigned)

Comment 5 by mar...@chromium.org, Jan 17 2017

Blocking: 661390
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/83e5bed8895f64f184dd994d721420835c9cbb64

commit 83e5bed8895f64f184dd994d721420835c9cbb64
Author: maruel <maruel@chromium.org>
Date: Wed Jan 18 00:56:03 2017

swarming: Fix named cache support.

- Add support for named cache in swarming.py so it can be used via the CLI.
  - Reshuffled the swarming.py trigger option grouping to differentiate between
    properties and request metadata.
- Add integration smoke test to ensure it actually work.
- Fix named cache bug, it didn't work: free_space wasn't initialized so all the
  named caches were deleted after use if min_free_space wasn't None.
- made min_free_space == 0 use the normal path.
- Add logging to help diagnose problems.

R=vadimsh@chromium.org
BUG= 667290 

Review-Url: https://codereview.chromium.org/2636993002

[modify] https://crrev.com/83e5bed8895f64f184dd994d721420835c9cbb64/appengine/swarming/local_smoke_test.py
[modify] https://crrev.com/83e5bed8895f64f184dd994d721420835c9cbb64/appengine/swarming/tools/start_bot.py
[modify] https://crrev.com/83e5bed8895f64f184dd994d721420835c9cbb64/client/named_cache.py
[modify] https://crrev.com/83e5bed8895f64f184dd994d721420835c9cbb64/client/swarming.py
[modify] https://crrev.com/83e5bed8895f64f184dd994d721420835c9cbb64/client/tests/swarming_test.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/83e5bed8895f64f184dd994d721420835c9cbb64

commit 83e5bed8895f64f184dd994d721420835c9cbb64
Author: maruel <maruel@chromium.org>
Date: Wed Jan 18 00:56:03 2017

swarming: Fix named cache support.

- Add support for named cache in swarming.py so it can be used via the CLI.
  - Reshuffled the swarming.py trigger option grouping to differentiate between
    properties and request metadata.
- Add integration smoke test to ensure it actually work.
- Fix named cache bug, it didn't work: free_space wasn't initialized so all the
  named caches were deleted after use if min_free_space wasn't None.
- made min_free_space == 0 use the normal path.
- Add logging to help diagnose problems.

R=vadimsh@chromium.org
BUG= 667290 

Review-Url: https://codereview.chromium.org/2636993002

[modify] https://crrev.com/83e5bed8895f64f184dd994d721420835c9cbb64/appengine/swarming/local_smoke_test.py
[modify] https://crrev.com/83e5bed8895f64f184dd994d721420835c9cbb64/appengine/swarming/tools/start_bot.py
[modify] https://crrev.com/83e5bed8895f64f184dd994d721420835c9cbb64/client/named_cache.py
[modify] https://crrev.com/83e5bed8895f64f184dd994d721420835c9cbb64/client/swarming.py
[modify] https://crrev.com/83e5bed8895f64f184dd994d721420835c9cbb64/client/tests/swarming_test.py

Comment 8 by mar...@chromium.org, Jan 18 2017

Status: Fixed (was: Started)

Sign in to add a comment