New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667283 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

AArch64 Linux build is broken due to missing packages from the sysroot

Reported by ossy.sze...@gmail.com, Nov 21 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 5.1; rv:50.0) Gecko/20100101 Firefox/50.0

Steps to reproduce the problem:
After https://chromiumcodereview.appspot.com/2444473002/ the AArch64 Linux build is broken due to missing packages from the default sysroot.

build log:
The ARM64 build is broken after this change, because gtk-3.0 packages
were added to sysroots, but libxkbcommon0 is still missing.

$ gn gen out/
ERROR at //build/config/linux/pkg_config.gni:85:17: Script returned non-zero exit code.
    pkgresult = exec_script(pkg_config_script, args, "value")
                ^----------
Current dir: /home/oszi/chromium/src/out/
Command: python -- /home/oszi/chromium/src/build/config/linux/pkg-config.py -s /home/oszi/chromium/src/build/linux/debian_jessie_arm64-sysroot -a arm64 gmodule-2.0 gtk+-3.0 gthread-2.0
Returned 1.
stderr:

Package xkbcommon was not found in the pkg-config search path.
Perhaps you should add the directory containing `xkbcommon.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xkbcommon', required by 'gdk-3.0', not found
Could not run pkg-config.

See //build/config/linux/gtk3/BUILD.gn:14:1: whence it was called.
pkg_config("gtk3_internal_config") {
^-----------------------------------
See //chrome/browser/ui/libgtkui/BUILD.gn:144:12: which caused the file to be included.
           "//build/config/linux/gtk3",
           ^--------------------------

Adding 3 packages to the sysroot fixed this issue for me. But unfortunately I can't prepare a CL for this, because I don't have right to upload updated sysroot to Google Cloud Storage.

build/linux/sysroot_scripts/packagelist.jessie.arm64
-----------------------------------------------------
+main/a/at-spi2-atk/libatk-bridge2.0-dev_2.14.0-2_arm64.deb
+main/a/at-spi2-core/libatspi2.0-dev_2.14.0-1_arm64.deb
+main/libx/libxkbcommon/libxkbcommon-dev_0.4.3-2_arm64.deb

build/linux/sysroot_scripts/sysroot-creator-jessie.sh
------------------------------------------------------
+  libxkbcommon-dev
+  libatk-bridge2.0-dev
+  libatspi2.0-dev

What is the expected behavior?

What went wrong?
build

Did this work before? Yes bcb34061acbe90a5ca4e73a50e12f9ecf2141758~1

Chrome version:   Channel: n/a
OS Version: 
Flash Version:
 
Owner: thomasanderson@chromium.org
Cc: gov...@chromium.org ligim...@chromium.org bustamante@chromium.org
Components: Build
Labels: -Type-Bug -Pri-2 M-56 Pri-1 Type-Bug-Regression
Adding current Dev Milestone.

Is this going to impact official/continuous builders? We are planning a Dev release tomorrow.
Status: Started (was: Unconfirmed)
> Is this going to impact official/continuous builders? We are planning a Dev release tomorrow.

I don't think it should, but I'll try to update the sysroots within the next few hours anyway.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26c12d2c62c8d726cee13d2a8a2c003196c5ce48

commit 26c12d2c62c8d726cee13d2a8a2c003196c5ce48
Author: thomasanderson <thomasanderson@google.com>
Date: Tue Nov 22 11:26:07 2016

Upload new Jessie sysroots

CL https://chromiumcodereview.appspot.com/2444473002/ added gtk3 dev
files to the sysroots, however there were additional dependencies of
gtk3 for Jessie/arm64.  CL https://codereview.chromium.org/2516343002
added the necessary dependencies to the sysroot scripts, and finally
this CL uploads the new sysroots.

BUG= 667283 
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2519223002
Cr-Commit-Position: refs/heads/master@{#433836}

[modify] https://crrev.com/26c12d2c62c8d726cee13d2a8a2c003196c5ce48/build/linux/sysroot_scripts/install-sysroot.py

Status: Fixed (was: Started)

Sign in to add a comment