mini_installer reads/writes in HKCU for system-level installs |
|||||
Issue descriptionmini_installer.exe is missing the check for the GoogleUpdateIsMachine environment variable. In some cases, it may access HKCU rather than HKLM when performing a system-level install or update.
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3fe8957ee4142309e5becdd611ea46b96ed8bc8 commit e3fe8957ee4142309e5becdd611ea46b96ed8bc8 Author: grt <grt@chromium.org> Date: Mon Nov 21 14:15:12 2016 Fix system-level detection in the mini_installer. Check for GoogleUpdateIsMachine=1 in the environment to detect system-level operations. BUG= 667268 Review-Url: https://codereview.chromium.org/2522433002 Cr-Commit-Position: refs/heads/master@{#433531} [modify] https://crrev.com/e3fe8957ee4142309e5becdd611ea46b96ed8bc8/chrome/installer/mini_installer/configuration.cc [modify] https://crrev.com/e3fe8957ee4142309e5becdd611ea46b96ed8bc8/chrome/installer/mini_installer/configuration.h [modify] https://crrev.com/e3fe8957ee4142309e5becdd611ea46b96ed8bc8/chrome/installer/mini_installer/configuration_test.cc
,
Nov 22 2016
,
Dec 21 2016
Fix shipped to dev in 57.0.2950.4 and looks good. Requesting merge to M56.
,
Dec 21 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f32b6800cf89f39f53b80daf857477c1fccd2449 commit f32b6800cf89f39f53b80daf857477c1fccd2449 Author: Julian Pastarmov <pastarmovj@chromium.org> Date: Wed Dec 21 08:53:39 2016 Fix system-level detection in the mini_installer. Check for GoogleUpdateIsMachine=1 in the environment to detect system-level operations. BUG= 667268 Review-Url: https://codereview.chromium.org/2522433002 Cr-Commit-Position: refs/heads/master@{#433531} (cherry picked from commit e3fe8957ee4142309e5becdd611ea46b96ed8bc8) Review-Url: https://codereview.chromium.org/2595863002 . Cr-Commit-Position: refs/branch-heads/2924@{#574} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/f32b6800cf89f39f53b80daf857477c1fccd2449/chrome/installer/mini_installer/configuration.cc [modify] https://crrev.com/f32b6800cf89f39f53b80daf857477c1fccd2449/chrome/installer/mini_installer/configuration.h [modify] https://crrev.com/f32b6800cf89f39f53b80daf857477c1fccd2449/chrome/installer/mini_installer/configuration_test.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by grt@chromium.org
, Nov 21 2016