New issue
Advanced search Search tips

Issue 667268 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

mini_installer reads/writes in HKCU for system-level installs

Project Member Reported by grt@chromium.org, Nov 21 2016

Issue description

mini_installer.exe is missing the check for the GoogleUpdateIsMachine environment variable. In some cases, it may access HKCU rather than HKLM when performing a system-level install or update.
 

Comment 1 by grt@chromium.org, Nov 21 2016

I think this is also contributing to INSTALLER_ERROR_OTHER+110 update failures. I think we should aggressively merge the fix up through the channels if it looks safe on dev. Canary won't provide any useful data since it is never installed at system-level.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21 2016

Comment 3 by grt@chromium.org, Nov 22 2016

Status: Fixed (was: Started)

Comment 4 by grt@chromium.org, Dec 21 2016

Labels: Merge-Request-56
Fix shipped to dev in 57.0.2950.4 and looks good. Requesting merge to M56.

Comment 5 by dimu@chromium.org, Dec 21 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 21 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f32b6800cf89f39f53b80daf857477c1fccd2449

commit f32b6800cf89f39f53b80daf857477c1fccd2449
Author: Julian Pastarmov <pastarmovj@chromium.org>
Date: Wed Dec 21 08:53:39 2016

Fix system-level detection in the mini_installer.

Check for GoogleUpdateIsMachine=1 in the environment to detect
system-level operations.

BUG= 667268 

Review-Url: https://codereview.chromium.org/2522433002
Cr-Commit-Position: refs/heads/master@{#433531}
(cherry picked from commit e3fe8957ee4142309e5becdd611ea46b96ed8bc8)

Review-Url: https://codereview.chromium.org/2595863002 .
Cr-Commit-Position: refs/branch-heads/2924@{#574}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/f32b6800cf89f39f53b80daf857477c1fccd2449/chrome/installer/mini_installer/configuration.cc
[modify] https://crrev.com/f32b6800cf89f39f53b80daf857477c1fccd2449/chrome/installer/mini_installer/configuration.h
[modify] https://crrev.com/f32b6800cf89f39f53b80daf857477c1fccd2449/chrome/installer/mini_installer/configuration_test.cc

Sign in to add a comment