New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667245 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Use other robhogan account instead.
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Traces of grey layer is seen after unchecking "disk cache bytes written" checkbox.

Reported by jshan...@etouch.net, Nov 21 2016

Issue description

Chrome Version: 55.0.2883.59 (Official Build) beta 955e772956a140399de5d3cf35d6819d894ecd63-refs/branch-heads/2883@{#624} 32/64-bit. 
OS:Windows(7,8,8.1,10),Linux (14.04 LTS)


What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://net-internals/#timeline
(2)Click on "disk cache bytes written" checkbox such that grey layer appears.
(3)Now again click on checkbox and observe the grey layer(color)

Actual: Traces of grey layer is seen after unchecking "disk cache bytes written" checkbox. 

Expected: No such traces should be seen after unchecking "disk cache bytes written" checkbox. 

This is a regression issue broken in 'M52' and below is the manual regression range.
Good Build: 52.0.2711.0 
Bad Build:  52.0.2712.0 

Note: Issue not seen on Mac OS.

 
Actual_traces.mp4
195 KB View Download
Expected_traces.mp4
193 KB View Download

Comment 1 by jshan...@etouch.net, Nov 21 2016

Labels: hasbisect
Owner: robhogan@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/74d1a68fa838d973b6104ddb4af4d88881fb901c..de7ae34361ba945b6d1ec7b3c679fecf5d94d35b?pretty=fuller&n=10

Suspecting: 387862 ?
Just to to update the latest behavior of the bug, Issue is still observed in Windows 10 on chrome latest Canary M57-57.0.2928.0

robhogan@ Could you please let us know is there any recent update available on this issue?

Thanks!
Labels: -Pri-1 -M-55 M-56 Pri-2
Cc: wangxianzhu@chromium.org
Tried and failed to create a reduction for this. wangxianzhu - could you have a quick go?
It seems related to glyph overflow of the full block character (U+2588) in the following piece of HTML:

<ul id="timeline-view-selection-ul">
  ...
  <li id="timeline-view-disk-cache-bytes-written"><label><input type="checkbox">
    █ <span class="timeline-view-text">Disk cache bytes written</span></label>
  </li>
</ul>

When the checkbox is clicked, the whole <li> is set style "color: white". It seems that the paint invalidation rect doesn't cover enough area of the glyph overflow of the character.

This has nothing to do with tables. I suggest you look at how the CL changes overflow calculation behavior.
Still able to reproduce the issue on windows 10 using chrome version 57.0.2976.5.

robhogan@ Could you please look into this issue.


Project Member

Comment 7 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38feb8be2c217b36fd46b228a69e31337fffe67e

commit 38feb8be2c217b36fd46b228a69e31337fffe67e
Author: robhogan <robhogan@gmail.com>
Date: Sat Feb 25 13:36:06 2017

Calculate glyph overflow when computing overflow outside of layout

Compute glyph overflow on the fly when we don't have it from a layout
pass. This ensures any glyph overflow is properly invalidated when we're
doing an overflow-only recalc after a style change.

BUG= 667245 

Review-Url: https://codereview.chromium.org/2688413002
Cr-Commit-Position: refs/heads/master@{#453087}

[add] https://crrev.com/38feb8be2c217b36fd46b228a69e31337fffe67e/third_party/WebKit/ManualTests/overflow-on-text-beside-form-element.html
[modify] https://crrev.com/38feb8be2c217b36fd46b228a69e31337fffe67e/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

Comment 8 by robho...@gmail.com, Jul 30 2017

Status: Fixed (was: Assigned)

Sign in to add a comment