New issue
Advanced search Search tips

Issue 667238 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
haraken@chromium.org
yutak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 737403
issue 738331
issue 738337


Sign in to add a comment

Clean up and document macros used in Blink

Project Member Reported by haraken@chromium.org, Nov 21 2016 
We should unify Blink's macros with Chromium's ones as much as possible. And we should document them.

See this spreadsheet: https://docs.google.com/spreadsheets/d/1AZtNeaUN_2YTbm4GhCGuy6V19PaDm4cqGElkfZyo2ug/edit#gid=0

Comment 1 by haraken@chromium.org, Nov 21 2016

Status: Available (was: Untriaged)

Comment 2 by tkent@chromium.org, Jun 28 2017

Blockedon: 737403
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56cc3c1bee04c0bd207d33c27e35863b7ed19783

commit 56cc3c1bee04c0bd207d33c27e35863b7ed19783
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Jun 29 10:40:45 2017

Remove some ARM-related macros.

This CL removes the following macros because they are used only in CPU.h.
- WTF_ARM_ARCH_VERSION
- WTF_THUMB_ARCH_VERSION
- WTF_CPU_ARM_THUMB2

Bug: 667238
Change-Id: I64327fae9b652a27ef4a8603d50ba8e161525205
Reviewed-on: https://chromium-review.googlesource.com/554419
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483319}
[modify] https://crrev.com/56cc3c1bee04c0bd207d33c27e35863b7ed19783/third_party/WebKit/Source/platform/wtf/CPU.h

Comment 5 by tkent@chromium.org, Jun 30 2017

Blockedon: 738331

Comment 6 by tkent@chromium.org, Jun 30 2017

Blockedon: 738337
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/518be28a99692aca461ce04d92b14baa396cfadc

commit 518be28a99692aca461ce04d92b14baa396cfadc
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Jul 06 08:37:03 2017

Remove ENABLE() macro.

This macro requires an undefined-but-common behavior of C preprocessor,
and is not used widely.

Bug: 667238
Change-Id: Ie6b500527f0ff4102becd9883ebcbf83a8406406
Reviewed-on: https://chromium-review.googlesource.com/560932
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484498}
[modify] https://crrev.com/518be28a99692aca461ce04d92b14baa396cfadc/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/518be28a99692aca461ce04d92b14baa396cfadc/third_party/WebKit/Source/platform/heap/HeapPage.cpp
[modify] https://crrev.com/518be28a99692aca461ce04d92b14baa396cfadc/third_party/WebKit/Source/platform/loader/fetch/RawResource.h
[modify] https://crrev.com/518be28a99692aca461ce04d92b14baa396cfadc/third_party/WebKit/Source/platform/wtf/Assertions.h
[modify] https://crrev.com/518be28a99692aca461ce04d92b14baa396cfadc/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp
[modify] https://crrev.com/518be28a99692aca461ce04d92b14baa396cfadc/third_party/WebKit/Source/platform/wtf/HashTable.h
[modify] https://crrev.com/518be28a99692aca461ce04d92b14baa396cfadc/third_party/WebKit/Source/platform/wtf/RefCounted.h
[modify] https://crrev.com/518be28a99692aca461ce04d92b14baa396cfadc/third_party/WebKit/Source/platform/wtf/SizeLimits.cpp
[modify] https://crrev.com/518be28a99692aca461ce04d92b14baa396cfadc/third_party/WebKit/Source/platform/wtf/build_config.h
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0af28eae30f36eb79e03054a5ae71973e23d6e4e

commit 0af28eae30f36eb79e03054a5ae71973e23d6e4e
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Jul 11 07:24:50 2017

Remove USE() macro.

This macro requires an undefined-but-common behavior of C preprocessor,
and is not used widely.

We can simply replace USE(FOO) with defined(WTF_USE_FOO).
WTF_USE_FOO macros are usually defined in BUILD.gn.

As for WTF_USE_APPLE_SYSTEM_LOG, we don't need this macro because
we support only macOS 10.9+.

Bug: 667238
Change-Id: I55c6b952bc9d77744ccd3e9b0a241e3093b10c46
Reviewed-on: https://chromium-review.googlesource.com/566343
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485548}
[modify] https://crrev.com/0af28eae30f36eb79e03054a5ae71973e23d6e4e/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp
[modify] https://crrev.com/0af28eae30f36eb79e03054a5ae71973e23d6e4e/third_party/WebKit/Source/platform/audio/AudioArray.h
[modify] https://crrev.com/0af28eae30f36eb79e03054a5ae71973e23d6e4e/third_party/WebKit/Source/platform/audio/FFTFrame.h
[modify] https://crrev.com/0af28eae30f36eb79e03054a5ae71973e23d6e4e/third_party/WebKit/Source/platform/audio/FFTFrameStub.cpp
[modify] https://crrev.com/0af28eae30f36eb79e03054a5ae71973e23d6e4e/third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp
[modify] https://crrev.com/0af28eae30f36eb79e03054a5ae71973e23d6e4e/third_party/WebKit/Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp
[modify] https://crrev.com/0af28eae30f36eb79e03054a5ae71973e23d6e4e/third_party/WebKit/Source/platform/graphics/GraphicsTypes.h
[modify] https://crrev.com/0af28eae30f36eb79e03054a5ae71973e23d6e4e/third_party/WebKit/Source/platform/wtf/Assertions.cpp
[modify] https://crrev.com/0af28eae30f36eb79e03054a5ae71973e23d6e4e/third_party/WebKit/Source/platform/wtf/DynamicAnnotations.cpp
[modify] https://crrev.com/0af28eae30f36eb79e03054a5ae71973e23d6e4e/third_party/WebKit/Source/platform/wtf/DynamicAnnotations.h
[modify] https://crrev.com/0af28eae30f36eb79e03054a5ae71973e23d6e4e/third_party/WebKit/Source/platform/wtf/RetainPtr.h
[modify] https://crrev.com/0af28eae30f36eb79e03054a5ae71973e23d6e4e/third_party/WebKit/Source/platform/wtf/build_config.h
[modify] https://crrev.com/0af28eae30f36eb79e03054a5ae71973e23d6e4e/third_party/WebKit/Source/web/WebViewImpl.cpp
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cdb34553e54c70cba547881959fba15ecad6d12

commit 5cdb34553e54c70cba547881959fba15ecad6d12
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Jul 24 05:44:40 2017

Remove HAVE() macro.

This macro requires an undefined-but-common behavior of C preprocessor,
and is not used widely.

Bug: 667238
Change-Id: Ic51982d96228a6410c25154849ca88b731c49f11
Reviewed-on: https://chromium-review.googlesource.com/582054
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488917}
[modify] https://crrev.com/5cdb34553e54c70cba547881959fba15ecad6d12/third_party/WebKit/Source/platform/audio/DenormalDisabler.h
[modify] https://crrev.com/5cdb34553e54c70cba547881959fba15ecad6d12/third_party/WebKit/Source/platform/audio/VectorMath.cpp
[modify] https://crrev.com/5cdb34553e54c70cba547881959fba15ecad6d12/third_party/WebKit/Source/platform/graphics/cpu/mips/WebGLImageConversionMSA.h
[modify] https://crrev.com/5cdb34553e54c70cba547881959fba15ecad6d12/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
[modify] https://crrev.com/5cdb34553e54c70cba547881959fba15ecad6d12/third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp
[modify] https://crrev.com/5cdb34553e54c70cba547881959fba15ecad6d12/third_party/WebKit/Source/platform/wtf/CPU.h
[modify] https://crrev.com/5cdb34553e54c70cba547881959fba15ecad6d12/third_party/WebKit/Source/platform/wtf/build_config.h
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e6a205057c96fc8d21537edf8549750cfb7c798

commit 6e6a205057c96fc8d21537edf8549750cfb7c798
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Jul 24 11:10:19 2017

Remove wtf/build_config.h

This file contains only a check for unsupported platforms. It is not helpful
because this check hides actual build issues.

Bug: 667238
Change-Id: Ibcaf0409cb49f84717119bb8ce0d1ff32469231b
Reviewed-on: https://chromium-review.googlesource.com/582672
Commit-Queue: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488943}
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/build/scripts/templates/RuntimeEnabledFeatures.h.tmpl
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/modules/webaudio/AudioBuffer.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/modules/webaudio/AudioNode.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/SecureTextInput.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/audio/AudioArray.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/audio/AudioUtilities.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/audio/Cone.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/audio/DistanceEffect.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/audio/Panner.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/audio/VectorMath.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/audio/mac/FFTFrameMac.cpp
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/clipboard/ClipboardUtilities.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/exported/WebAudioBus.cpp
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/graphics/GraphicsTypes.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/mediastream/MediaStreamWebAudioSource.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/wtf/AddressSanitizer.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/wtf/BUILD.gn
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/wtf/ByteOrder.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/wtf/DynamicAnnotations.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/wtf/README.md
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/wtf/StackUtil.h
[modify] https://crrev.com/6e6a205057c96fc8d21537edf8549750cfb7c798/third_party/WebKit/Source/platform/wtf/StringExtras.h
[delete] https://crrev.com/d914a23721d371b22715a5805ada2e65bc7d2cf8/third_party/WebKit/Source/platform/wtf/build_config.h
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 24

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by yutak@chromium.org, Jul 25

Status: Available (was: Untriaged)
►

Sign in to add a comment